fix(discovery): support PSR-4 paths defined as arrays in composer.json#2112
Draft
nayleen wants to merge 1 commit intotempestphp:3.xfrom
Draft
fix(discovery): support PSR-4 paths defined as arrays in composer.json#2112nayleen wants to merge 1 commit intotempestphp:3.xfrom
nayleen wants to merge 1 commit intotempestphp:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reproduces the error I'm seeing in a project using tempest/discovery standalone.
The issue most likely affects the main framework as well due to a assumption in the Discovery Composer.php class that PSR-4 namespaces only map to a single path, even though Composer's schema allows both
stringandlist<string>:https://getcomposer.org/doc/04-schema.md#psr-4
{ "autoload": { "psr-4": { "Monolog\\": ["src/", "lib/"] } } }As per the contribution guidelines I've only submitted the failing test, even though I gave a fix a shot already.
You'll find the patch in the following Gist: https://gist.github.com/nayleen/1696e073c98c98f7b822ed51927e3350
The test reproduces the exact error I'm seeing: