Skip to content

fix(database): make orderBy support all dialects#2120

Open
laylatichy wants to merge 2 commits intotempestphp:3.xfrom
laylatichy:fix-orderby-quotes
Open

fix(database): make orderBy support all dialects#2120
laylatichy wants to merge 2 commits intotempestphp:3.xfrom
laylatichy:fix-orderby-quotes

Conversation

@laylatichy
Copy link
Copy Markdown
Contributor

@laylatichy laylatichy commented Apr 17, 2026

orderBy('table.column') emitted ORDER BY `table.column` instead of ORDER BY `table`.`column`

for orderbyraw I wasnt sure if we want separate class so I used RawStatement

OrderByStatement|RawStatement

but if you prefer creating something like OrderByRawStatement let me know

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

Benchmark Results

Comparison of fix-orderby-quotes against 3.x (9d11469f3c62f2922865eb2a80f7109cf15eee9a).

Open to see the benchmark results
Benchmark Set Mem. Peak Time Variability
ViewRenderBench(benchPlainHtml) - 21.965mb 0.00% 467.582μs -12.86% ±1.72% -46.91%
DiscoveryScanBench(benchFullDiscoveryScan) - 24.343mb -0.01% 15.586ms -5.80% ±2.15% -19.56%

Generated by phpbench against commit 38e5c15

@laylatichy laylatichy marked this pull request as ready for review April 17, 2026 17:05
@innocenzi innocenzi changed the title fix(database): order by quoting fix(database): make orderBy support all dialects Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants