fix(database): make orderBy support all dialects#2120
Open
laylatichy wants to merge 2 commits intotempestphp:3.xfrom
Open
fix(database): make orderBy support all dialects#2120laylatichy wants to merge 2 commits intotempestphp:3.xfrom
orderBy support all dialects#2120laylatichy wants to merge 2 commits intotempestphp:3.xfrom
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 38e5c15 |
78c61ef to
914dea9
Compare
914dea9 to
38e5c15
Compare
orderBy support all dialects
innocenzi
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orderBy('table.column')emittedORDER BY `table.column`instead ofORDER BY `table`.`column`for orderbyraw I wasnt sure if we want separate class so I used RawStatement
OrderByStatement|RawStatement
but if you prefer creating something like OrderByRawStatement let me know