Add configurable validation interval and connectivity health status#60
Draft
smuneebahmad wants to merge 1 commit into
Draft
Add configurable validation interval and connectivity health status#60smuneebahmad wants to merge 1 commit into
smuneebahmad wants to merge 1 commit into
Conversation
smuneebahmad
force-pushed
the
muneeb/wci-validation
branch
from
4de11b0 to
d0f5794
Compare
smuneebahmad
force-pushed
the
muneeb/wci-validation
branch
from
d0f5794 to
c3ad59a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
WCI now signals the version workflow whenever its connectivity validation status changes (on config save, periodic check, "Validate Connection", or a scaling invocation failure). This enables the deployment workflow to maintain an up-to-date aggregate connectivity summary in its memo
Why?
Enables surfacing the connectivity health between Temporal and a customer's compute resource (e.g. Lambda) through the Worker Deployments API, so the UI can show ongoing validations status of compute configs without additional queries.
Checklist
Closes https://temporalio.atlassian.net/browse/COM-143
How was this tested:
Deployed to a test cell and verified that connectivity status updates correctly after triggering "Validate Connection" and after a failed Lambda invocation. Confirmed the version workflow receives the signal and the deployment workflow memo is updated accordingly.