Reduce TestEnv object leaks#10771
Open
stephanos wants to merge 46 commits into
Open
Conversation
stephanos
commented
Jun 18, 2026
| dedicatedGuard: dedicatedGuard, | ||
| } | ||
| dedicatedGuardRef := &dedicatedGuard | ||
| t.Cleanup(func() { |
Contributor
Author
There was a problem hiding this comment.
So this is interesting; the t.Cleanup keeps these references alive and prevents GC until the test completes. Only then is the Cleanup closure GC itself. So this means in longer suites with several tests, the clusters are all accumulating until the very end. By nil-ing them, we force that to happen sooner.
stephanos
force-pushed
the
stephanos/object-leak-cleanup
branch
3 times, most recently
from
dc4d2cf to
ad085c8
Compare
stephanos
force-pushed
the
stephanos/object-leak-cleanup
branch
from
457eb7d to
5d5c197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Reduce TestEnv object leaks by explicitly
nil-ing fields int.Cleanup.Why?
Reduce object leaks after cluster teardown.