-
Notifications
You must be signed in to change notification settings - Fork 219
Fix/docs nav #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix/docs nav #624
Conversation
b3cae41 to
e50a22e
Compare
docs/docs/install.md
Outdated
|
|
||
| *Note: To use TensorFlow on Android, see | ||
| [TensorFlow Lite](https://tensorflow.org/lite)* | ||
| [TensorFlow LiteRT](https://tensorflow.org/lite)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just called LiteRT now, they dropped the TensorFlow.
| @@ -0,0 +1,125 @@ | |||
| # Lint as: python3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
| @@ -0,0 +1,98 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes as in the PR description, I thought it could be good to preserve a copy of those in case some courageous developers want to try generating our docs with DocLava in the future... but no, we don't need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the docs/tools folder to docs/legacy but let me know if you prefer me to drop it entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I failed at reading the PR description. Might be an idea to update the doc string at the top of each file to say they are from the old documentation generation system and no longer used.
Added navigation and landing page(s) for docs site. Also include updates in generated files to link to the latest version of JavaCPP
Note: I know that the docs tools are no longer being used, in favor of Maven, but I thought keeping them in the source tree could be useful if later we want to revisit that choice (hopefully not ;) )