Repository navigation
Avoid preview hangs caused by idle browser connections - #733
Open
Chessing234 wants to merge 1 commit into
Open
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A browser can open a TCP connection before sending an HTTP request. The single-threaded preview server then waits on that socket and cannot answer another connection, making the preview appear hung. Use the standard-library
ThreadingHTTPServerso idle preconnections do not block active requests.Validation: the socket regression waits until the idle connection is accepted, then requests the favicon over a second connection. It times out with the current server and receives 204 with this change.
python3 -m unittest discover -s testsand whitespace checks pass. No Lean changes.AI assistance: OpenAI Codex.