Repository navigation
Keep preview symlink targets inside the generated site - #735
Open
Chessing234 wants to merge 1 commit into
Open
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview server's lexical path check rejects
..escapes but follows symlinks outside the generated site when serving files. Resolve both the site root and candidate path before checking containment, so an external symlink target is rejected while internal links and a symlinked checkout continue to work.Validation: an external-link fixture is served by the baseline and rejected after the fix; the internal-link/symlinked-root case still passes. Both unittest cases and Python compilation pass. Open and recently closed PRs were checked for symlink containment; no overlap. Existing preview PRs change routing, working-directory anchoring, and concurrency rather than this helper.
git diff --checkpasses.