Skip to content

Add typing - #31

Merged
jelmer merged 1 commit into
testing-cabal:masterfrom
stephenfin:typing
Aug 23, 2026
Merged

jelmer merged 1 commit into
testing-cabal:masterfrom
stephenfin:typing

Conversation

@stephenfin

@stephenfin stephenfin commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Per $subject

@jelmer

jelmer commented Aug 23, 2026

Copy link
Copy Markdown
Member

Any chance you can submit these as separate PRs?

@stephenfin

Copy link
Copy Markdown
Contributor Author

Any chance you can submit these as separate PRs?

I can, but the NEWS will conflict. I'll submit that in a separate PR with the expectation it'll be merged after the other two.

@stephenfin stephenfin closed this Aug 23, 2026
@stephenfin stephenfin reopened this Aug 23, 2026
@stephenfin

Copy link
Copy Markdown
Contributor Author

Any chance you can submit these as separate PRs?

I can, but the NEWS will conflict. I'll submit that in a separate PR with the expectation it'll be merged after the other two.

Actually, I depend on the ruff changes for these typing change. I've submitted those separately at #32. Let's make this as draft until we're happy with that.

@stephenfin
stephenfin marked this pull request as draft August 23, 2026 16:37
We also add a lint hatch env rather than integrating tox here.

Signed-off-by: Stephen Finucane <stephen@that.guru>
@stephenfin stephenfin changed the title Add typing + release v0.7.0 Add typing Aug 23, 2026
@stephenfin
stephenfin marked this pull request as ready for review August 23, 2026 16:49
@stephenfin stephenfin mentioned this pull request Aug 23, 2026
@jelmer

jelmer commented Aug 23, 2026

Copy link
Copy Markdown
Member

Any chance you can submit these as separate PRs?

I can, but the NEWS will conflict. I'll submit that in a separate PR with the expectation it'll be merged after the other two.

Actually, I depend on the ruff changes for these typing change. I've submitted those separately at #32. Let's make this as draft until we're happy with that.

Thanks, I appreciate it! I realize it's a bit of a hassle.

@jelmer
jelmer merged commit 612ef98 into testing-cabal:master Aug 23, 2026
7 checks passed
@stephenfin
stephenfin deleted the typing branch August 23, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants