fix(deps): lift tiptap, js-yaml and nodemailer past three high advisories - #26
Merged
Merged
Conversation
…ries The audit gate started failing every pull request today on three high advisories reachable from the running service: - @tiptap/core GHSA-j95f-988m-3j2f, quadratic ReDoS in Markdown attribute parsing (fixed in 3.30.5). The core/pm/suggestion overrides move from 3.30.1 to 3.30.6, the last patch of the minor we run; the extension packages stay at 3.30.2, as they were already ahead of the pinned core. This also clears the moderate mergeAttributes `__proto__` advisory. - js-yaml GHSA-2883-xcg3-v3hh, merge-key CPU exhaustion (fixed in 4.3.2). Transitive via the TanStack start plugin; the override moves 4.3.1 -> 4.3.2. - nodemailer GHSA-2x7j-588g-ccc2, quadratic addressparser (fixed in 9.1.0), plus three moderate recipient-domain validation bypasses fixed in 9.1.1. packages/email moves from ^9.0.5 to ^9.1.1, staying on major 9. After deploying: outbound mail goes through nodemailer 9.1.1, whose address parser rejects recipient strings it used to mis-parse (RFC 5322 comments, IDN look-alikes); nothing else in the running service changes. The lockfile diff is exactly these five packages. Typecheck, lint, the editor, e-mail, sanitizer and shared suites (836 tests) and the audit gate pass locally. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The audit gate (
bun scripts/audit-check.ts, part of the requiredcheckjob) started failing every pull request today, first seen on #25, on three high advisories reachable from the running service:@tiptap/corejs-yamlnodemailerpackages/email^9.0.5 → ^9.1.1Staying on the minors we run: tiptap 3.30.x (the extension packages were already at 3.30.2, ahead of the pinned core), nodemailer major 9. The tiptap bump also clears the moderate
mergeAttributes__proto__advisory; nodemailer 9.1.1 also clears three moderate recipient-domain validation bypasses.What changes after deploying
Outbound mail goes through nodemailer 9.1.1, whose address parser rejects recipient strings it used to mis-parse (RFC 5322 comments, IDN look-alikes). Nothing else in the running service changes.
Verification
PASS: no un-allowlisted production high/critical advisories., typecheck 0 errors, lint unchanged (two pre-existing warnings), editor + e-mail + sanitizer + shared suites: 836 passed, 4 skipped.🤖 Generated with Claude Code