Add sorting in case of duplicate Fks pointing to same table#300
Open
nguyenk wants to merge 1 commit intothecodingmachine:masterfrom
Open
Add sorting in case of duplicate Fks pointing to same table#300nguyenk wants to merge 1 commit intothecodingmachine:masterfrom
nguyenk wants to merge 1 commit intothecodingmachine:masterfrom
Conversation
Collaborator
|
If I'm right the foreign keys might come from different tables. On MySQL the foreign key name should be unique per table. Hence it is possible to have the same name for both, leading to unstable sort. An option would be to include the "from" table name in the sort function (I know that some of those functions are deprecated and will be removed in dbal 4, not sure for the one we would use here). Should this sort go in the schema analyzer or here ? Do we want to add a test for this (this is maybe doable using a hand created schema). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.