Feat/theme hook - #36
Open
robinallezard wants to merge 4 commits into
Open
Conversation
anoziere
reviewed
Jul 28, 2026
anoziere
left a comment
Contributor
There was a problem hiding this comment.
The theme-hook approach looks right and matches the SEOne/flexy work. Two behavior changes deserve a second look:
Service/DataLayerProvider.php(renderJsInit): the old code concatenatedrenderSelectItem()andrenderAddToCart()on listing views; the new version returns one template or the other.addToCart.jsis no longer loaded on category/brand/search/folder/content/page views, so add/remove cart tracking stops working wherever a listing page has an add-to-cart button.Listener/GoogleTagListener.php(trackPurchase):$event->getPlacedOrder()->getId()has no null check, andgetSession()throws when there is no request in scope. Payment modules can fireORDER_PAYfrom an IPN/webhook context, which would turn a tracking miss into a fatal during payment. Both calls should be guarded.
Minor points: {{ containerId }} in script.html.twig/noscript.html.twig is now HTML-escaped inside a script tag, where the old PHP string was raw, so an unusual configured value would corrupt the emitted JS instead of rendering as before. And gtm_js_init seems to have no remaining caller now that the hook renders it directly; if that's intentional, it could be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.