feat: add Thelia 3 bi-compat (default-twig BO, twig config, bank info renderer) - #4
Merged
Merged
Conversation
mabruchet
changed the title
added 3 commits
August 5, 2026 10:23
Removes the Smarty templates, the HookManager hook class and the isThelia3() / resolveDatabase() indirection. Front-office labels move to the module root domain: wiretransfer.fo.default only existed because Thelia derives that domain from templates/frontOffice/*, so deleting the Smarty directory would have unregistered the catalogue the bank-info renderer reads.
SendPaymentConfirmationEmail was declared in Config/config.xml as `send.wiretransfer.mail` AND auto-discovered by configureServices(). Two service ids for one subscriber class means Symfony registers two listeners on ORDER_UPDATE_STATUS, so the customer received the wire-transfer confirmation twice on every switch to paid. Auto-discovery alone is now authoritative. Also: - Drop the listener's unused ParserInterface dependency, which autowiring resolved to the throwing ParserFallback. - install(): pass $con straight to Database, whose constructor already accepts null and unwraps a ConnectionWrapper — the manual getWrappedConnection() was duplicating that and would fatal on the null the signature allows. Drop the dead argument to isModuleImageDeployed(), which declares no parameter. - Route the form labels through the trans() helper that existed unused. - Use the inherited $this->translator instead of an injected duplicate. - Correct the claim that Thelia 3 has no front-office hooks: it has ThemeHookInterface + theme_hook(), but the active theme declares no point.
ThemeHookInterface exists but nothing consumes its thelia.theme_hook tag and no theme_hook() Twig function is registered, so it cannot be used to render the bank details. The Twig function stays the only mechanism available today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.