Skip to content

add picket-fence hamiltonian tutorial#180

Closed
iamkagwe wants to merge 2 commits intotheochem:mainfrom
iamkagwe:feature/picket-fence-tutorial
Closed

add picket-fence hamiltonian tutorial#180
iamkagwe wants to merge 2 commits intotheochem:mainfrom
iamkagwe:feature/picket-fence-tutorial

Conversation

@iamkagwe
Copy link
Copy Markdown

@iamkagwe iamkagwe commented Mar 4, 2026

A new tutorial notebook examples/picket_fence.ipynb ( see #145 ) that demonstrates how to build a standard “picket-fence” pairing (Richardson–Gaudin) Hamiltonian using the HamRG class.

@PaulWAyers PaulWAyers requested a review from RichRick1 March 5, 2026 15:18
@PaulWAyers
Copy link
Copy Markdown
Member

@RichRick1 any thoughts on this? I'm happy to look at it next week too.

Copy link
Copy Markdown
Collaborator

@RichRick1 RichRick1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be interesting to compare results with ones available in literature and include FCI calculations too

@iamkagwe
Copy link
Copy Markdown
Author

@PaulWAyers @RichRick1 I submitted the initial picket-fence tutorial two months ago, referring to previous discussion and other tutorials. Without feedback or assigned issues, I noticed several duplicate PRs were opened after mine, turning this into competition rather than collaborative work.

#187 demonstrates valuable rigor (literature benchmarking + FCI validation) that should be the standard moving forward. Since you're happy with the merge of #187, I think this should be closed, and the other tutorials should be edited to match.

@RichRick1
Copy link
Copy Markdown
Collaborator

@iamkagwe we apologize for delaying reviewing your pull request. Unfortunately, we do need a way to access potential contributors, that's why some duplication in pull requests may occur. We agree that the current overlap in pull requests isn't ideal for a collaborative environment. We’re adjusting our evaluation and onboarding procedures now to ensure that contributors have clear feedback and that efforts aren't duplicated. We appreciate you bringing this to our attention.

@RichRick1 RichRick1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants