Repository navigation
fix(security): go 1.26.10, golang.org/x/crypto v0.58.0 - #13
Merged
shenzhaoyan merged 3 commits intoNov 2, 2026
Merged
shenzhaoyan merged 3 commits into
shenzhaoyan merged 3 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The Go toolchain requirement update has no active review issues.
No open issues 🎉
What changed in this PR
Raises the Go toolchain requirement for theplant/cachex to address the certificate-verification vulnerability described in the PR.
Changes:
- Updates the root
go.moddirective from Go 1.26.0 to 1.26.10.
| File | Description |
|---|---|
go.mod |
Raises the minimum required Go version to 1.26.10. |
Review effort: Balanced
x/net v0.58.0 was in the module graph (via x/crypto) with seven advisories: GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617 (HTTP/2, fixed in v0.60.0), and GO-2026-6860 and GO-2026-6866 (html, fixed in v0.62.0). x/crypto v0.58.0 on its own only lifts x/net to v0.60.0, so x/net v0.62.0 is required explicitly. cachex imports no x/net package, so `go mod tidy` drops that line and x/net falls back to v0.60.0 — keep it when tidying. Moved along by MVS: x/sync v0.24.0, x/sys v0.49.0, x/text v0.43.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cachex imports no x/net package, so tidy removes the v0.62.0 line. x/net now resolves to v0.60.0 through x/crypto v0.58.0, which still clears the five HTTP/2 advisories; GO-2026-6860 and GO-2026-6866 (x/net/html, fixed in v0.62.0) stay in the module graph but are not compiled into this module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shenzhaoyan
approved these changes
Nov 2, 2026
shenzhaoyan
deleted the
aikido-fix/aikido-security-APPSEC-925-update-packages-165523396-avtx
branch
November 2, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the Go toolchain to 1.26.10 and moves the golang.org/x modules forward;
go.mod/go.sumare exactly whatgo mod tidyproduces.go1.26.0 -> 1.26.10. The workflow reads its toolchain fromgo-version-file: go.mod, so the directive is the Go CI builds and tests with. 1.26.10 makes certificate verification reject the known compromised eMudhra intermediate CA keys; it also carries the 1.26.9 net/http HTTP/2 fixes (GO-2026-6603, -6610, -6611, -6612, -6617).golang.org/x/cryptov0.57.0 -> v0.58.0, the latest. It liftsgolang.org/x/netin the module graph from v0.58.0 to v0.60.0, which clears the same five HTTP/2 advisories there.golang.org/x/syncv0.24.0,golang.org/x/sysv0.49.0,golang.org/x/textv0.43.0.golang.org/x/netis not ingo.mod: cachex imports no x/net package, sogo mod tidydrops an explicit v0.62.0 requirement and x/net resolves to v0.60.0 through x/crypto. That leaves GO-2026-6860 and GO-2026-6866 (x/net/html, fixed in v0.62.0) in the module graph; they are not compiled into this module, and govulncheck does not report them. They clear once x/crypto (or another dependency) requires x/net v0.62.0+.Also not fixable by a version bump: GO-2026-5932 on x/crypto v0.58.0. It is the "openpgp is unmaintained" notice and has no fixed version (introduced: 0, no fix event). This module reaches x/crypto through gorm.io/driver/sqlserver -> go-mssqldb -> ntlm -> x/crypto/md4, not openpgp.
Verified with go1.26.10:
go mod tidyleaves no diff;go mod verify,go build -mod=readonly ./...,go vet ./...andgo test -short -p=1 -count=1 ./...pass; govulncheck reports nothing; an OSV pass over the fullgo list -m allgraph returns only the three advisories above.🤖 Generated with Claude Code