Remove function names from llogs #10509
Merged
+997
−998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
requested review from
a team,
LaurentiuM1234,
RanderWang,
abonislawski,
akloniex,
bardliao,
bhiregoudar,
dbaluta,
fkwasowi,
iganakov,
jxstelter,
kuanhsuncheng,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko,
plbossart,
ranj063,
singalsu,
sunilkumardommati,
tlissows and
yaochunhung
as code owners
There was a problem hiding this comment.
Pull request overview
Updates log strings across the firmware to remove function names and other verbose prefixes from logging output.
Changes:
- Simplifies trace/IPC/scheduler log messages by removing function-name prefixes.
- Standardizes many “entry/done” style messages and shortens error/warn strings across audio components and drivers.
- Applies the same logging cleanup across multiple platform clock and DMA/DAI drivers.
Reviewed changes
Copilot reviewed 112 out of 112 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/trace/trace.c | Removes function-name prefix from an allocation failure log. |
| src/trace/dma-trace.c | Shortens trace DMA logs and init messages. |
| src/schedule/zephyr_ll.c | Shortens scheduler error log text. |
| src/schedule/zephyr_domain.c | Removes function-name prefixes from domain register/unregister logs. |
| src/samples/audio/smart_amp_test_ipc4.c | Shortens smart amp sample logs (“entry”, size/error text). |
| src/samples/audio/smart_amp_test_ipc3.c | Shortens smart amp IPC3 sample logs and error strings. |
| src/samples/audio/kwd_nn_detect_test.c | Removes function-name prefix from KWD timing and detection logs. |
| src/samples/audio/detect_test.c | Shortens detect test logs (“entry”, config/size errors). |
| src/platform/mt8365/lib/clk.c | Shortens clk debug logs. |
| src/platform/mt8195/lib/clk.c | Shortens clk debug/info logs. |
| src/platform/mt8188/lib/clk.c | Shortens clk debug logs. |
| src/platform/mt8186/lib/clk.c | Shortens clk debug logs. |
| src/platform/amd/acp_7_0/lib/clk.c | Shortens ACP clock-notify logs. |
| src/platform/amd/acp_6_3/lib/clk.c | Shortens ACP clock-notify logs. |
| src/library_manager/lib_manager.c | Removes function-name prefix from allocation failure log. |
| src/lib/notifier.c | Shortens notifier allocation failure logs. |
| src/lib/dma.c | Shortens DMA put/remove logs. |
| src/lib/dai.c | Shortens DAI put/remove logs. |
| src/lib/ams.c | Shortens AMS slot processing log. |
| src/lib/agent.c | Shortens system agent init/validate logs. |
| src/ipc/ipc4/helper.c | Shortens IPC4 component-add debug log. |
| src/ipc/ipc4/handler.c | Shortens IPC4 handler debug/error logs. |
| src/ipc/ipc4/dai.c | Shortens IPC4 DAI config logs. |
| src/ipc/ipc3/handler.c | Shortens IPC3 DMA trace config failure log. |
| src/ipc/ipc3/dai.c | Shortens IPC3 DAI logs and allocation failure message. |
| src/ipc/ipc-helper.c | Shortens IPC pipeline-complete error logs. |
| src/drivers/mediatek/afe/afe-memif.c | Shortens AFE memif logs and error text. |
| src/drivers/mediatek/afe/afe-drv.c | Shortens AFE DAI get/set logs and invalid-id error text. |
| src/drivers/imx/sdma.c | Shortens SDMA logs (but introduces format-string issues). |
| src/drivers/imx/sai.c | Shortens SAI logs (some become effectively empty). |
| src/drivers/imx/micfil.c | Shortens micfil logs (“entry”, config text). |
| src/drivers/imx/interrupt-irqsteer.c | Removes function-name prefix from IRQ storm log. |
| src/drivers/imx/esai.c | Shortens ESAI logs and invalid-direction errors. |
| src/drivers/imx/edma.c | Shortens EDMA unsupported-direction logs. |
| src/drivers/dw/dma.c | Shortens DW DMA logs (retains a misspelling in changed lines). |
| src/drivers/amd/vangogh/acp_hs_dma.c | Shortens ACP HS DMA copy log. |
| src/drivers/amd/renoir/acp_sp_dai.c | Shortens invalid-direction error. |
| src/drivers/amd/rembrandt/acp_sw_audio_dai.c | Shortens remove log. |
| src/drivers/amd/rembrandt/acp_hs_dai.c | Shortens HS DAI error strings. |
| src/audio/volume/volume_ipc4.c | Shortens volume IPC4 logs (“entry”). |
| src/audio/volume/volume_ipc3.c | Shortens volume IPC3 debug/error logs. |
| src/audio/volume/volume.c | Shortens volume component logs (“entry”, clamp warnings). |
| src/audio/up_down_mixer/up_down_mixer.c | Shortens process log (“entry”). |
| src/audio/tone/tone.c | Shortens tone passthrough failure logs. |
| src/audio/tone/tone-ipc4.c | Shortens free log (“entry”). |
| src/audio/tone/tone-ipc3.c | Shortens tone IPC3 logs across cmd/prepare/reset/copy. |
| src/audio/tensorflow/tflm-classify.c | Shortens TFLM init/config/process logs. |
| src/audio/template/template.c | Shortens template component logs. |
| src/audio/template/template-ipc3.c | Shortens template IPC3 get/set config logs. |
| src/audio/tdfb/tdfb_ipc4.c | Shortens TDFB IPC4 logs. |
| src/audio/tdfb/tdfb_ipc3.c | Shortens TDFB IPC3 logs and error strings. |
| src/audio/tdfb/tdfb.c | Shortens TDFB core logs and error strings. |
| src/audio/stft_process/stft_process_setup.c | Shortens STFT setup logs (“entry/done”). |
| src/audio/stft_process/stft_process.c | Shortens STFT init log (“entry”). |
| src/audio/sound_dose/sound_dose.c | Shortens sound dose logs (“entry”). |
| src/audio/smart_amp/smart_amp_maxim_dsm.c | Shortens Maxim DSM error logs. |
| src/audio/smart_amp/smart_amp.c | Shortens smart amp logs (“entry”, command logs). |
| src/audio/selector/selector.c | Shortens selector logs (“entry”, command labels). |
| src/audio/rtnr/rtnr.c | Shortens RTNR logs and config/param messages. |
| src/audio/pipeline/pipeline-xrun.c | Shortens xrun recover log (“entry”). |
| src/audio/pipeline/pipeline-stream.c | Shortens pipeline stream debug messages. |
| src/audio/pipeline/pipeline-schedule.c | Shortens pipeline task debug logs (“entry/sched”). |
| src/audio/pipeline/pipeline-params.c | Shortens pipeline params debug logs. |
| src/audio/pipeline/pipeline-graph.c | Shortens pipeline free/complete/reset debug logs. |
| src/audio/nxp/eap.c | Shortens NXP EAP init/free/prepare/process logs. |
| src/audio/mux/mux_ipc3.c | Shortens mux IPC3 log (“entry”). |
| src/audio/mux/mux_generic.c | Shortens mux/demux debug logs. |
| src/audio/mux/mux.c | Shortens mux core logs (“entry”). |
| src/audio/multiband_drc/multiband_drc_ipc4.c | Shortens multiband DRC IPC4 logs. |
| src/audio/multiband_drc/multiband_drc_ipc3.c | Shortens multiband DRC IPC3 logs/warnings. |
| src/audio/multiband_drc/multiband_drc.c | Shortens multiband DRC core logs and errors. |
| src/audio/module_adapter/module_adapter_ipc3.c | Shortens module adapter logs/errors. |
| src/audio/mixer/mixer.c | Shortens mixer logs (“entry”, size logs). |
| src/audio/mfcc/mfcc_setup.c | Shortens MFCC setup logs (“entry/done”). |
| src/audio/mfcc/mfcc_common.c | Shortens MFCC STFT debug log text. |
| src/audio/mfcc/mfcc.c | Shortens MFCC init/get/set/prepare/process logs. |
| src/audio/level_multiplier/level_multiplier.c | Shortens level multiplier logs (“entry”). |
| src/audio/kpb.c | Shortens KPB logs across scheduling/trigger/copy/drain. |
| src/audio/igo_nr/igo_nr.c | Shortens IGO NR logs and error messages. |
| src/audio/host-zephyr.c | Shortens host-zephyr logs (“entry”, EOS text). |
| src/audio/host-legacy.c | Shortens host-legacy logs (“entry”, DMA copy failure log). |
| src/audio/google/google_rtc_audio_processing.c | Shortens Google RTC audio processing logs. |
| src/audio/google/google_hotword_detect.c | Shortens Google hotword detect logs (“entry”). |
| src/audio/google/google_ctc_audio_processing_ipc3.c | Shortens CTC IPC3 set-config log. |
| src/audio/google/google_ctc_audio_processing.c | Shortens CTC logs (“entry”, error text). |
| src/audio/eq_iir/eq_iir_ipc4.c | Shortens EQ IIR IPC4 logs (“entry”, active/pass-through). |
| src/audio/eq_iir/eq_iir_ipc3.c | Shortens EQ IIR IPC3 logs (“entry”, active/pass-through). |
| src/audio/eq_iir/eq_iir_generic.c | Shortens EQ IIR generic logs and errors. |
| src/audio/eq_iir/eq_iir.c | Shortens EQ IIR core logs and error strings. |
| src/audio/eq_fir/eq_fir_ipc4.c | Shortens EQ FIR IPC4 logs and error string. |
| src/audio/eq_fir/eq_fir_ipc3.c | Shortens EQ FIR IPC3 logs and error string. |
| src/audio/eq_fir/eq_fir.c | Shortens EQ FIR core logs and error strings. |
| src/audio/drc/drc.c | Shortens DRC logs and “illegal control/bytes control” strings. |
| src/audio/dcblock/dcblock_ipc4.c | Shortens DCBlock IPC4 logs (“entry”). |
| src/audio/dcblock/dcblock.c | Shortens DCBlock logs and error strings. |
| src/audio/data_blob.c | Shortens data blob handler logs and error strings. |
| src/audio/dai-zephyr.c | Shortens DAI Zephyr logs (“entry”, error text). |
| src/audio/dai-legacy.c | Shortens DAI legacy logs and trigger text. |
| src/audio/crossover/crossover_ipc4.c | Shortens crossover IPC4 logs/warnings (“entry”). |
| src/audio/crossover/crossover_ipc3.c | Shortens crossover IPC3 logs/warnings. |
| src/audio/crossover/crossover.c | Shortens crossover core logs/errors. |
| src/audio/copier/copier_host.c | Shortens copier host DMA callback logs. |
| src/audio/copier/copier.c | Shortens copier logs and mic privacy logs. |
| src/audio/component.c | Shortens comp_set_state / EOS debug logs. |
| src/audio/codec/dts/dts.c | Shortens DTS codec logs (“start/done/failed”). |
| src/audio/buffers/comp_buffer.c | Shortens buffer debug/error logs. |
| src/audio/asrc/asrc_farrow.c | Shortens ASRC farrow error logs. |
| src/audio/asrc/asrc.c | Shortens ASRC logs (including set_config error log). |
| src/audio/aria/aria.c | Shortens ARIA logs (“entry”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove function names from logging calls. They're added automatically by Zephyr. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Remove function names from logging calls. They're added automatically by Zephyr. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Remove function names from logging calls. They're added automatically by Zephyr. Signed-off-by: Guennadi Liakhovetski <[email protected]>
singalsu
approved these changes
Jan 30, 2026
kv2019i
approved these changes
Jan 30, 2026
Collaborator
|
Merging this quiclly as this will affect all PRs before and after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so, copilot, this is what I meant...