Feat: add WithRequest as a type and the callback#26
Draft
bote795 wants to merge 1 commit into
Draft
Conversation
Author
|
@thgh how do you usually test this? would I do a yarn link? |
thgh
reviewed
Jun 26, 2024
| extends BaseOAuthPluginOptions, | ||
| StrategyOptionsWithRequest { | ||
| /** | ||
| * With this option enabled, req will be passed as the first argument to the verify callback. |
Owner
There was a problem hiding this comment.
How about always passing the request as last argument to the verify callback?
Owner
|
I'm not using this package as my needs changed over time 🥲 Ideally, there would be a vitest integration test that spawns an http server and simulates the oauth flow. |
Owner
|
Check out this test 🙌 |
Author
thanks, ill check it out! need to get some time to do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to pass the request to the verification function this allows the user to connect a currently loggined in user to w/e auth provider they are trying to login
Will be tested after learning how to test
notes: