Skip to content

[SDK] Add name and picture fields to Profile type for Apple Sign In compliance #8681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AKSHEXXXX wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

[SDK] Add name and picture fields to Profile type for Apple Sign In compliance #8681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/apple-profile-name-picture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": minor
---

Add optional `name` and `picture` fields to `Profile` type to support additional OAuth provider data (Google, Apple, etc.). The UI now displays the user's name when available from OAuth providers, improving Apple Sign In compliance.
5 changes: 5 additions & 0 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/screens/LinkedProfilesScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ import { MenuButton } from "../MenuButton.js";
import type { WalletDetailsModalScreen } from "./types.js";

function getProfileDisplayName(profile: Profile) {
// Prefer name if available (from OAuth providers like Google/Apple)
if (profile.details.name) {
return profile.details.name;
}
Comment on lines +27 to +30
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name field handling in getProfileDisplayName looks good and will correctly prioritize the user's full name from OAuth providers. However, there are no test cases added to verify this new behavior. Consider adding a test case that verifies when a profile has both name and email (e.g., for a Google profile), the name is displayed rather than the email address.

Copilot uses AI. Check for mistakes.

switch (true) {
case profile.type === "email" && profile.details.email !== undefined:
return profile.details.email;
Expand Down
2 changes: 2 additions & 0 deletions packages/thirdweb/src/wallets/in-app/core/authentication/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ export type Profile = {
email?: string;
phone?: string;
address?: Address;
name?: string;
picture?: string;
};
};

Expand Down
Loading