Skip to content

Connect modal approval changeset#8686

Merged
joaquim-verges merged 1 commit intomainfrom
cursor/connect-modal-approval-changeset-cc3d
Feb 24, 2026
Merged

Connect modal approval changeset#8686
joaquim-verges merged 1 commit intomainfrom
cursor/connect-modal-approval-changeset-cc3d

Conversation

@Yash094
Copy link
Member

@Yash094 Yash094 commented Feb 24, 2026

[SDK] Feature: Add changeset for 'requireApproval' option in useConnectModal

Notes for the reviewer

This changeset documents the addition of the requireApproval option to the useConnectModal hook. It is marked as a minor version bump as it introduces a new public API option.

How to test

Verify the content and format of the .changeset/connect-modal-require-approval.md file.


Slack Thread

Open in Web Open in Cursor 


PR-Codex overview

This PR introduces a new feature in the useConnectModal hook, which requires users to accept the terms of service and privacy policy before they can connect their in-app wallet.

Detailed summary

  • Added requireApproval option to useConnectModal hook.
  • Users must accept terms of service and privacy policy to connect their wallet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added requireApproval option to enforce acceptance of terms of service and privacy policy before in-app wallet connection.

Co-authored-by: Yash <Yash094@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-v2 Building Building Preview, Comment Feb 24, 2026 9:34am
nebula Ready Ready Preview, Comment Feb 24, 2026 9:34am
thirdweb_playground Ready Ready Preview, Comment Feb 24, 2026 9:34am
thirdweb-www Ready Ready Preview, Comment Feb 24, 2026 9:34am
wallet-ui Ready Ready Preview, Comment Feb 24, 2026 9:34am

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: f8892c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Minor
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor
Copy link

cursor bot commented Feb 24, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between decbbb8 and f8892c8.

📒 Files selected for processing (1)
  • .changeset/connect-modal-require-approval.md

Walkthrough

Adds a changelog entry documenting a new requireApproval option for the useConnectModal hook that enforces acceptance of terms of service and privacy policy before in-app wallet connection.

Changes

Cohort / File(s) Summary
Changelog Entry
.changeset/connect-modal-require-approval.md
New minor version changelog entry documenting the requireApproval option for useConnectModal hook, which enforces ToS and privacy policy acceptance before wallet connection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #8683: Implements the actual requireApproval prop for UseConnectModalOptions and passes it through the modal component.

Suggested labels

packages

Suggested reviewers

  • joaquim-verges
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Connect modal approval changeset' is specific and directly related to the main change—adding a changeset for the requireApproval option in useConnectModal.
Description check ✅ Passed The description follows the template structure with proper sections: feature tag [SDK], descriptive title, notes for reviewer, and how to test. All required components are present and well-documented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/connect-modal-approval-changeset-cc3d

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yash094 Yash094 marked this pull request as ready for review February 24, 2026 09:33
@joaquim-verges joaquim-verges merged commit 5352152 into main Feb 24, 2026
22 of 24 checks passed
@joaquim-verges joaquim-verges deleted the cursor/connect-modal-approval-changeset-cc3d branch February 24, 2026 09:36
@joaquim-verges joaquim-verges mentioned this pull request Feb 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.72%. Comparing base (1caf6dd) to head (f8892c8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8686   +/-   ##
=======================================
  Coverage   52.72%   52.72%           
=======================================
  Files         934      934           
  Lines       62965    62965           
  Branches     4134     4134           
=======================================
  Hits        33197    33197           
  Misses      29670    29670           
  Partials       98       98           
Flag Coverage Δ
packages 52.72% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants