create_list does not correctly override parameter

[GMolini]

Description

Ive got a factory bot definition like this

FactoryBot.define do
  factory :emails_message, class: 'Emails::Message' do
    subject { Faker::Lorem.sentence }
    thread_subject { Faker::Lorem.sentence }
    from { Faker::Internet.unique.email }
    from_display_name { "#{Faker::Name.name} <#{from}>" }
  end
end

If I create a list like this:

  email_address = "test@example.com"
  emails = create_list(:emails_message, 10, from: email_address)

Its very weird because it uses the correct from in the from_display_name, but is incorrectly saved in the from attribute

If I print the emails: p emails.map { |r| [r.from, r.from_display_name] }

[["daniela.graham@jast.test", "Prof. Trudi Langosh <test@example.com>"], ["marlys@robel-schmeler.test", "Courtney Becker <test@example.com>"], ["antoine@metz.test", "Ollie Steuber <test@example.com>"], ["sue_harber@medhurst.example", "Johnathan Marvin <test@example.com>"], ["maximo@prosacco-grant.example", "Jacinto O'Reilly <test@example.com>"], ["lindsey@schulist.example", "Mrs. Thanh Schinner <test@example.com>"], ["dominique@kuvalis-wehner.test", "Stevie Larson <test@example.com>"], ["manda@thiel-ziemann.test", "Alena Abbott MD <test@example.com>"], ["fabian.grady@leffler-bechtelar.test", "Lavona Becker Ret. <test@example.com>"], ["gilberto_gleichner@rau.test", "Msgr. Vada Rolfson <test@example.com>"]]

System configuration

factory_bot version: 6.2.1
rails version: 7.0.8
ruby version: 3.2.2

Edit: Ive updated factory_bot to version 6.5.5 and factory_bot_rails to 6.5.1 and it still happens

[SergiuLupaiescu]

Not sure if this is still valid, but could you include a minimal reproduction script for this issue? See here: https://github.com/thoughtbot/factory_bot/blob/main/.github/REPRODUCTION_SCRIPT.rb

Some further questions would be:

• is this happening with a single create call also? Or with build_list?
• how does the Emails::Message model looks like? Are there any custom setters like from= or before_save callbacks? - here would come in handy to have the reproduction script mentioned above

[antarr]

@GMolini

I tested this with a minimal ActiveRecord setup using the factory shape from the issue.

With a plain Emails::Message model, no callbacks and no custom setters, the override works as expected on both factory_bot 6.2.1 and 6.5.5. create, build, create_list, and build_list all keep from == "test@example.com".

I was only able to reproduce the mismatch when I added a model callback that rewrites self.from during validation/save. In that case, from_display_name still contains "test@example.com", but the saved from value gets replaced. build_list still works because it does not run the save callbacks.

Can you check Emails::Message for anything that touches from during persistence? I would look for a before_validation, before_save, before_create, a custom from= setter, or a concern that assigns sender/from fields.

Based on the repro, FactoryBot appears to be setting the override correctly, and something in the model layer is changing it before the record is saved.