Assign attribute_lists in a single write - #1837
Open
stefanlew-tractive wants to merge 1 commit into
Open
Conversation
EvaluatorClassDefiner#evaluator_class writes attribute_lists and then
reads it back in the next statement. attribute_lists is a
class_attribute, so the write goes through ActiveSupport's generated
writer and the read comes back through the generated reader. When the
value is not observable on that second read, `+` is called on nil:
NoMethodError: undefined method '+' for nil
lib/factory_bot/evaluator_class_definer.rb:16:in 'block in evaluator_class'
Collapsing the pair into one read-modify-write removes the window.
Behaviour is unchanged: a fresh subclass still starts from an empty
list, and a child evaluator still accumulates its parent's lists.
stefanlew-tractive
requested review from
neilvcarvalho and
vburzynski
as code owners
September 9, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvaluatorClassDefiner#evaluator_classwritesattribute_lists, then reads it back on the nextline:
attribute_listsis aclass_attribute, so the write goes through ActiveSupport's generated writerand the second statement re-reads through the generated reader. If that read does not observe the
write,
+is called onnil:Reproduction against 6.6.0:
This collapses the pair into a single read-modify-write, so the value is never read back after being
written. Behaviour is unchanged: a fresh subclass still starts from an empty list, and a child
evaluator still accumulates its parent's lists. The added spec fails on
mainand passes with thechange.