ci(tbtc/signer): pin workflow actions to commit SHAs; disable checkout credential persistence#4127
Merged
mswilkison merged 2 commits intoJul 2, 2026
Conversation
…t credential persistence Resolves the zizmor/CodeRabbit findings on the signer formal-verification workflow: unpinned mutable action tags and persisted git credentials in checkout steps. All `uses:` references now pin full commit SHAs with human-readable version comments (actions/checkout v4.3.1, dtolnay/rust-toolchain stable head, EmbarkStudios/cargo-deny-action v2.0.20, actions/setup-java v4.8.0), and every checkout step sets persist-credentials: false so the ephemeral token is not written to the local git config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
added a commit
that referenced
this pull request
Jul 2, 2026
…teps Codex P2 review on #4127: dtolnay/rust-toolchain defaults its installed toolchain to the action ref. Once the action is pinned by commit SHA (as this workflow now does for supply-chain hardening) that ref is no longer "stable", so the Setup Rust steps would try to install the SHA as a rustup toolchain and the signer Rust/formal jobs fail. Keep the SHA pin and name the toolchain explicitly (`toolchain: stable`) on both Setup Rust steps. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codex P2 review on #4127 flagged that SHA-pinning dtolnay/rust-toolchain could make it install the SHA as a toolchain, since older versions of the action derive the default toolchain from the action ref. Verified against the pinned version (4be7066): its action.yml already defaults `toolchain` to `stable`, so the Setup Rust / formal jobs were not actually broken (they pass on this branch). Still, name the toolchain explicitly on both Setup Rust steps: it is self-documenting and independent of the pinned action's default, which is the safe form for a SHA-pinned toolchain action. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mswilkison
force-pushed
the
ci/signer-formal-workflow-hardening
branch
from
5cb4083 to
3010172
Compare
mswilkison
merged commit 911f3b6
into
extraction/frost-signer-mirror-2026-05-26
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
.github/workflows/tbtc-signer-formal.yml(introduced in #4005) against supply-chain and credential-exposure risks:actions/checkoutstep now setspersist-credentials: false, so the ephemeralGITHUB_TOKENis not persisted into the local git config after checkout. None of the jobs perform authenticated git operations after checkout, so nothing relies on the persisted credential.uses:reference is pinned to a full 40-hex commit SHA with a trailing comment recording the human-readable version, replacing mutable tag/branch refs. No action major versions were changed — each pin is the current commit behind the ref that was already in use.This addresses the two open CodeRabbit review threads on #4005 (persisted checkout credentials + unpinned action refs on
.github/workflows/tbtc-signer-formal.yml).Pinned actions
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5(v4.3.1)dtolnay/rust-toolchainstable4be7066ada62dd38de10e7b70166bc74ed198c30(stable branch head)EmbarkStudios/cargo-deny-actionv2bb137d7af7e4fb67e5f82a49c4fce4fad40782fe(v2.0.20)actions/setup-javav4c1e323688fd81a25caa38c78aa6df2d33d3e20d9(v4.8.0)Notes
extraction/frost-signer-mirror-2026-05-26(PR feat(tbtc/signer): FROST/ROAST Rust signer #4005); only the workflow file is touched.🤖 Generated with Claude Code