fix(web): add missing exec timestamps to ToolCard test fixture#1057
Merged
Conversation
The ChatToolCall fixture in ToolCard.test.ts does not set execStartedAt and execCompletedAt, which became required fields, so bun typecheck fails on main with TS2739. The fixture was added while those fields did not exist yet, and the change that introduced them landed a minute earlier, so each side type-checked against its own base and the gap only appears once both are on main. Set both to null, matching the sibling fixtures in ToolGroupCard.test.ts and groupedPresentation.test.ts, since these cases do not exercise tool execution duration.
There was a problem hiding this comment.
Findings
No issues found in the changed lines.
Questions
None.
Summary
Review mode: initial
No findings. The fixture now includes the required execStartedAt and execCompletedAt fields, matching the surrounding test fixture pattern that uses null when execution duration is not under test. Residual risk is limited to unrun automation in this review pass.
Testing
Not run (automation).
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bun typecheckfails onmain:The
testworkflow runsbun typecheckbeforebun run test, so the job stops there and thetestcheck goes red for any PR whose workflow runs after this point (#1054 and #1056 so far). PRs whose workflow last ran earlier still show a green check.#1036 made
execStartedAtandexecCompletedAtrequired onChatToolCalland updated the fixtures that existed at the time. My #1045 added a new fixture toToolCard.test.ts, written against a base from before those fields existed, and the two landed about a minute apart - so each branch type-checked cleanly against its own base and the gap only appears with both onmain. Sorry for the noise.Fix
Set both fields to
nullin the fixture, matching the sibling fixtures inToolGroupCard.test.tsandgroupedPresentation.test.ts, since these cases do not exercise tool execution duration.Tests
On this branch
bun typecheckis clean andbun run testpasses across cli, hub, web and shared.@tiann - flagging for visibility since this blocks the
testcheck for new runs.AI disclosure (per CONTRIBUTING.md): Claude Opus 4.8.