fix(codex): use supported safe-yolo approval policy#1079
Merged
Conversation
There was a problem hiding this comment.
Findings
No issues found in the added/modified lines.
Summary
Review mode: initial
No diff-anchored blocker/major/minor findings. Residual risk: remote resume does not have a direct launcher-level assertion for safe-yolo approval params, but the shared thread-param helper now has start/resume-relevant coverage and the local launcher assertion was updated.
Testing
Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe-yolo's removedon-failureapproval policy withon-requestworkspace-writesandbox and HAPI auto-approval behaviorProblem
Codex CLI 0.144.x no longer accepts
on-failure. Starting or resuming a HAPI Codex session insafe-yolomode sends that value tothread/startorthread/resume, which fails immediately with:For resumed sessions, the user-facing result is:
on-requestpreserves sandbox escalation support, while HAPI's existingCodexPermissionHandlercontinues to auto-approve requests insafe-yolomode.Testing
bun typecheckbun run test(CLI, hub, web, and shared suites)AI disclosure
This focused fix and its tests were prepared with OpenAI Codex assistance and manually verified against Codex CLI 0.144.x behavior.