Rename allow-tigera Tier to calico-system#4438
Open
radixo wants to merge 2 commits intotigera:masterfrom
Open
Conversation
The change was made by only replacing the following patterns in all files: - s/\ballow-tigera\b/calico-system/g - s/allowTigera/calicoSystem/g - s/AllowTigera/CalicoSystem/g
tiers_controller implementation to send to tiers render the objects needed to clean up the allow-tigera deprecated tier.
Member
caseydavenport
left a comment
caseydavenport
left a comment
There was a problem hiding this comment.
A couple of small comments but overall looking like what I expected!
| return &tiersConfig, nil | ||
| } | ||
|
|
||
| func (r *ReconcileTiers) fetchDeprecatedObjs(ctx context.Context, tiersConfig *tiers.Config) (err error) { |
Member
There was a problem hiding this comment.
Generally easier to read if the code doesn't use side-effects like this and just returns the objects instead of modifying the input.
That said, we should know exactly which objects we need to delete without querying the cluster, right?
What happens if a user has created their own policy within the allow-tigera tier? What will our code do? What should our code do?
I think it probably needs to spot that and abort, warning the user? WDYT?
| } | ||
|
|
||
| // Deprecate allow-tigera Tier | ||
| allowTigeraClusterDNSPolicy := t.calicoSystemClusterDNSPolicy() |
Member
There was a problem hiding this comment.
Why do we need this explicitly here? Shouldn't it already be part of DeprecatedObjs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames allow-tigera Tier to calico-system with the purpose to enable this Tier on Calico OSS.
All the files were changed only applying regex replaces on a few allow-tigera patterns.
Specially for the tigera-operator a cleanup routine was appended to tier's controller and render.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.