Skip to content

fix(istio): set platform=gke on istiod and ztunnel charts#4463

Merged
electricjesus merged 2 commits intomasterfrom
seth/fix-istio-gke-platform
Mar 5, 2026
Merged

fix(istio): set platform=gke on istiod and ztunnel charts#4463
electricjesus merged 2 commits intomasterfrom
seth/fix-istio-gke-platform

Conversation

@electricjesus
Copy link
Member

@electricjesus electricjesus commented Feb 23, 2026

Summary

  • global.platform was only being set to gke on the CNI chart, leaving istiod and ztunnel without GKE-specific profile configurations
  • Added platform=gke to IstiodOpts.Global and ZTunnelOpts.Global alongside IstioCNIOpts.Global, matching the pattern used for OpenShift in fix(istio): Set platform=openshift for istio on OpenShift #4402
  • This enables the ztunnel ResourceQuota and sets PLATFORM=gke on istiod's discovery container

Test plan

  • Updated GKE test: object count 33 → 34 (ztunnel ResourceQuota now rendered)
  • Updated GKE test: ztunnel ResourceQuota added to expected resources
  • New test: PLATFORM=gke env var on istiod discovery container
  • Full go test ./pkg/render/istio/ passes (33/33 specs)
Fix Istio GKE platform detection: set platform=gke on istiod and ztunnel Helm charts in addition to the CNI chart, enabling the ztunnel ResourceQuota and PLATFORM=gke environment variable on istiod.

Closes: EV-6377
Related: EV-6376, #4402

@electricjesus electricjesus force-pushed the seth/fix-istio-gke-platform branch from 9931f28 to 9f408af Compare March 5, 2026 09:27
The GKE platform was only being set on the CNI chart opts, leaving
istiod and ztunnel without their GKE-specific profile configurations.
This caused ztunnel to miss a ResourceQuota and istiod to have a blank
PLATFORM env var instead of "gke".

Set global.platform=gke on IstiodOpts and ZTunnelOpts alongside
IstioCNIOpts, matching the pattern already used for OpenShift.

Closes: EV-6377
Related: EV-6376
@electricjesus electricjesus force-pushed the seth/fix-istio-gke-platform branch from 9f408af to 45e8466 Compare March 5, 2026 11:24
@electricjesus electricjesus merged commit 4812d5b into master Mar 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants