Add MetricsPort to Goldmane operator API#4498
Open
caseydavenport wants to merge 2 commits intotigera:masterfrom
Open
Add MetricsPort to Goldmane operator API#4498caseydavenport wants to merge 2 commits intotigera:masterfrom
caseydavenport wants to merge 2 commits intotigera:masterfrom
Conversation
Allow users to enable Prometheus metrics on Goldmane by setting spec.metricsPort on the Goldmane CR. When configured, the operator sets the PROMETHEUS_PORT env var on the container, creates a headless metrics Service with prometheus.io annotations for scrape discovery, and opens the port in the NetworkPolicy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
metricsPortfield to the Goldmane CR spec so that Prometheus metrics can be enabled without needing to bypass the operator. When set:PROMETHEUS_PORTenv var on the Goldmane containergoldmane-metricsService withprometheus.io/scrapeandprometheus.io/portannotationsWhen unset (or zero), the metrics service is cleaned up and no env var is set.
Usage: