Update PHPUnit from attributes to annotation - #220
Draft
mattstauffer wants to merge 1 commit into
Draft
Conversation
Contributor
|
I think we should adopt this as Duster's Pint default, but release it as a major version. Since this change drops PHPUnit 9 support because it won't pickup What do you think about shipping this as the next mayor version and highlighting PHPUnit 10+ as the baseline? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, Duster recommended/fixed to the PHPUnit now-deprecated annotations (
/** @test */). This PR updates it to use the new attributes (#[Test]).Here's the concern: it also re-writes every other PHPUnit annotation (
@dataProvider,@covers,@depends, …) into the attribute form.Pros
@param,@return,@var,@throws, …) alone.Cons
Closes #219