fix(storage): use correct header in isMigrated#84
Conversation
Greptile SummaryThis PR switches
Confidence Score: 2/5Not safe to merge — the header key lookup is always a miss due to missing A P1 bug causes packages/storage/src/lib/object/migrate.ts — the header key lookup needs Important Files Changed
Reviews (1): Last reviewed commit: "fix(storage): use correct header in isMi..." | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6251273. Configure here.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Note
Medium Risk
Changes the logic that decides whether an object is considered migrated, which can affect read routing/behavior for storage objects. Risk is limited in scope but could cause incorrect migration state detection if upstream header values differ from expectations.
Overview
Updates
isMigratedto determine migration status by readingX-Tigris-Read-Sourcefrom theHeadObjectresponse and treatingblock_shadowas not migrated, replacing the prior check that inferred migration from the presence ofX-Tigris-Served-From.Adds the new
TigrisHeaders.READ_SOURCEenum value to standardize use of this header across the codebase.Reviewed by Cursor Bugbot for commit 32c3cce. Bugbot is set up for automated code reviews on this repo. Configure here.