Skip to content

build: pin tempfile to 3.14.0 for rust-toolchain 1.84.1#532

Open
pingyu wants to merge 1 commit intotikv:masterfrom
pingyu:pin-tempfile
Open

build: pin tempfile to 3.14.0 for rust-toolchain 1.84.1#532
pingyu wants to merge 1 commit intotikv:masterfrom
pingyu:pin-tempfile

Conversation

@pingyu
Copy link
Collaborator

@pingyu pingyu commented Feb 16, 2026

Problem

make fails on toolchain 1.84.1 during cargo run -p tikv-client-proto-build because dependency resolution can pick tempfile 3.25.0, which pulls getrandom 0.4.1 (requires Cargo support for edition2024).

Fix

  • Pin tempfile to =3.14.0 in Cargo.toml dev-dependencies.
  • Add the same pin in proto-build/Cargo.toml so generate is constrained even when Cargo.lock is ignored.

This keeps compatibility with the repository's pinned rust-toolchain.toml (1.84.1) and avoids the edition2024 parse failure.

Verification

  • make

Summary by CodeRabbit

  • Chores
    • Updated development dependency versions for compatibility with the latest Rust toolchain.

Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Feb 16, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign niedhui for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

📝 Walkthrough

Walkthrough

Dependency version pinning updates across two Cargo.toml manifests. The root project pins tempfile from version "3.6" to exact version "3.14.0", while proto-build adds tempfile as a new dependency with the same pinned version "3.14.0" alongside a rust-toolchain compatibility note.

Changes

Cohort / File(s) Summary
Dependency Version Pinning
Cargo.toml, proto-build/Cargo.toml
Updated/added tempfile dependency pinned to exact version 3.14.0 in both manifests. Root file changes from flexible "3.6" to exact "=3.14.0"; proto-build adds new dependency with rust-toolchain 1.84.1 compatibility note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A carrot of version, precisely aligned,
Dependencies bundled, no mismatch to find,
Three-fourteen-zero, locked tight with a pin,
Building with confidence—let the work begin! 📦

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: pinning tempfile to a specific version for rust-toolchain compatibility, which is the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Cargo.toml (1)

60-60: Consider adding the same compatibility comment as in proto-build/Cargo.toml.

The sibling manifest has # Keep this compatible with rust-toolchain 1.84.1. above its tempfile pin. Adding the same note here would help future contributors understand why an exact pin is used and when it can be relaxed.

Suggested change
+# Keep this compatible with rust-toolchain 1.84.1.
 tempfile = "=3.14.0"

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 16, 2026

@iosmanthus @YuJuncen PTAL~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments