build: pin tempfile to 3.14.0 for rust-toolchain 1.84.1#532
build: pin tempfile to 3.14.0 for rust-toolchain 1.84.1#532pingyu wants to merge 1 commit intotikv:masterfrom
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughDependency version pinning updates across two Cargo.toml manifests. The root project pins tempfile from version "3.6" to exact version "3.14.0", while proto-build adds tempfile as a new dependency with the same pinned version "3.14.0" alongside a rust-toolchain compatibility note. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Cargo.toml (1)
60-60: Consider adding the same compatibility comment as inproto-build/Cargo.toml.The sibling manifest has
# Keep this compatible with rust-toolchain 1.84.1.above itstempfilepin. Adding the same note here would help future contributors understand why an exact pin is used and when it can be relaxed.Suggested change
+# Keep this compatible with rust-toolchain 1.84.1. tempfile = "=3.14.0"
|
@iosmanthus @YuJuncen PTAL~ |
Problem
makefails on toolchain1.84.1duringcargo run -p tikv-client-proto-buildbecause dependency resolution can picktempfile 3.25.0, which pullsgetrandom 0.4.1(requires Cargo support for edition2024).Fix
tempfileto=3.14.0inCargo.tomldev-dependencies.proto-build/Cargo.tomlsogenerateis constrained even whenCargo.lockis ignored.This keeps compatibility with the repository's pinned
rust-toolchain.toml(1.84.1) and avoids theedition2024parse failure.Verification
makeSummary by CodeRabbit