Skip to content

fix: align proxy transport requirements#112

Merged
sachaservan merged 1 commit into
mainfrom
fix/align-proxy-transport-requirements
Jul 11, 2026
Merged

fix: align proxy transport requirements#112
sachaservan merged 1 commit into
mainfrom
fix/align-proxy-transport-requirements

Conversation

@sachaservan

@sachaservan sachaservan commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Align proxy transport rules by allowing http proxies for EHBP and enforcing strict origin binding (scheme, host, port) to prevent header disclosure. base_url is now optional and URLs are validated more strictly.

  • Bug Fixes
    • Accept http base_url for EHBP; keep attestation_bundle_url https-only.
    • Validate base_url/attestation_bundle_url as absolute http(s) URLs; reject malformed or non-HTTP schemes.
    • Enforce exact origin binding for enclave/proxy (scheme, host, port), including correct defaults for 80/443; block unconfigured HTTP and foreign hosts.
    • In tls transport, require base_url to match the verified enclave origin; otherwise raise.
    • Make base_url Optional in SecureClient/NewSecureClient and avoid adding the enclave URL header when proxy and enclave share the same origin.

Written for commit 26c865f. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/tinfoil/client.py
@sachaservan sachaservan merged commit 2418326 into main Jul 11, 2026
2 checks passed
@sachaservan sachaservan deleted the fix/align-proxy-transport-requirements branch July 11, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant