fix: align proxy transport requirements#112
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Align proxy transport rules by allowing
httpproxies for EHBP and enforcing strict origin binding (scheme, host, port) to prevent header disclosure.base_urlis now optional and URLs are validated more strictly.httpbase_urlfor EHBP; keepattestation_bundle_urlhttps-only.base_url/attestation_bundle_urlas absolutehttp(s)URLs; reject malformed or non-HTTP schemes.tlstransport, requirebase_urlto match the verified enclave origin; otherwise raise.base_urlOptional inSecureClient/NewSecureClientand avoid adding the enclave URL header when proxy and enclave share the same origin.Written for commit 26c865f. Summary will update on new commits.