Skip to content

static-network: set metric 50 on ipam= default route - #79

Merged
mergify[bot] merged 1 commit into
tinkerbell:mainfrom
rpardini:pr/static-network-set-metric-50-on-ipam-default-route
Oct 27, 2026
Merged

mergify[bot] merged 1 commit into
tinkerbell:mainfrom
rpardini:pr/static-network-set-metric-50-on-ipam-default-route

Conversation

@rpardini

Copy link
Copy Markdown
Member
  • 🌴 80-dhcp.network sets RouteMetric=100; setting the ipam= one to 50 makes it preferred over auto-configured interfaces
  • 🌱 move the ipam= gateway from [Network] Gateway= to a [Route] section, as Gateway doesn't take a metric
  • 🌿 emit [Route] last, after DNS=/NTP=/Domains=, so those keys stay in [Network]
  • 🌵 log the gateway and metric

- `80-dhcp.network` sets RouteMetric=100; setting the `ipam=` one to 50 makes it preferred over auto-configured interfaces
- move the `ipam=` gateway from `[Network] Gateway=` to a `[Route]` section, as Gateway doesn't take a metric
- emit `[Route]` last, after `DNS=`/`NTP=`/`Domains=`, so those keys stay in `[Network]`
- log the gateway and metric

Assisted-by: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
@rpardini
rpardini marked this pull request as ready for review October 21, 2026 11:59
@jacobweinstock jacobweinstock added the ready-to-merge Signal Mergify to merge the PR label Oct 27, 2026
@mergify mergify Bot added the queued label Oct 27, 2026
@mergify

mergify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into main as c114c06 at 16:01 UTC

28 min in the queue, 26 min of it CI.

So far

Merge conditions: 40 of 40 met

This pull request

Condition Required by
✅ #changes-requested-reviews-by=0 —
✅ github-review-approved GitHub repository ruleset rule main
✅ label!=do-not-merge —
✅ label=ready-to-merge —
✅ queue-position>=0 —
✅ any of: #approved-reviews-by>=1, author=jacobweinstock —

The batch, tested on draft #80

Condition Required by
✅ base=main —
✅ check-success=DCO —
✅ check-success=build-captainos (with kernel) trixie-slim (amd64) —
✅ check-success=build-captainos (with kernel) trixie-slim (arm64) —
✅ check-success=build-captainos trixie-armbian-rpi (arm64) —
✅ check-success=build-captainos trixie-full (amd64) —
✅ check-success=build-captainos trixie-full (arm64) —
✅ check-success=build-captainos trixie-genio (arm64) —
✅ check-success=build-captainos trixie-meson64 (arm64) —
✅ check-success=build-captainos trixie-rockchip64 (arm64) —
✅ check-success=build-captainos trixie-rockchip64-vendor (arm64) —
✅ check-success=build-captainos-kernel (amd64) —
✅ check-success=build-captainos-kernel (arm64) —
✅ check-success=build-dockerfile (amd64) —
✅ check-success=build-dockerfile (arm64) —
✅ check-success=download-tools (amd64) —
✅ check-success=download-tools (arm64) —
✅ check-success=prepare —
✅ any of: check-success = @github-actions/download-tools (amd64), check-neutral = @github-actions/download-tools (amd64), check-skipped = @github-actions/download-tools (amd64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/download-tools (arm64), check-neutral = @github-actions/download-tools (arm64), check-skipped = @github-actions/download-tools (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos (with kernel) trixie-slim (amd64), check-neutral = @github-actions/build-captainos (with kernel) trixie-slim (amd64), check-skipped = @github-actions/build-captainos (with kernel) trixie-slim (amd64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos (with kernel) trixie-slim (arm64), check-neutral = @github-actions/build-captainos (with kernel) trixie-slim (arm64), check-skipped = @github-actions/build-captainos (with kernel) trixie-slim (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-armbian-rpi (arm64), check-neutral = @github-actions/build-captainos trixie-armbian-rpi (arm64), check-skipped = @github-actions/build-captainos trixie-armbian-rpi (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-full (amd64), check-neutral = @github-actions/build-captainos trixie-full (amd64), check-skipped = @github-actions/build-captainos trixie-full (amd64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-full (arm64), check-neutral = @github-actions/build-captainos trixie-full (arm64), check-skipped = @github-actions/build-captainos trixie-full (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-genio (arm64), check-neutral = @github-actions/build-captainos trixie-genio (arm64), check-skipped = @github-actions/build-captainos trixie-genio (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-meson64 (arm64), check-neutral = @github-actions/build-captainos trixie-meson64 (arm64), check-skipped = @github-actions/build-captainos trixie-meson64 (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-rockchip64 (arm64), check-neutral = @github-actions/build-captainos trixie-rockchip64 (arm64), check-skipped = @github-actions/build-captainos trixie-rockchip64 (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos trixie-rockchip64-vendor (arm64), check-neutral = @github-actions/build-captainos trixie-rockchip64-vendor (arm64), check-skipped = @github-actions/build-captainos trixie-rockchip64-vendor (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos-kernel (amd64), check-neutral = @github-actions/build-captainos-kernel (amd64), check-skipped = @github-actions/build-captainos-kernel (amd64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/prepare, check-neutral = @github-actions/prepare, check-skipped = @github-actions/prepare GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-dockerfile (amd64), check-neutral = @github-actions/build-dockerfile (amd64), check-skipped = @github-actions/build-dockerfile (amd64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-dockerfile (arm64), check-neutral = @github-actions/build-dockerfile (arm64), check-skipped = @github-actions/build-dockerfile (arm64) GitHub repository ruleset rule main
✅ any of: check-success = @github-actions/build-captainos-kernel (arm64), check-neutral = @github-actions/build-captainos-kernel (arm64), check-skipped = @github-actions/build-captainos-kernel (arm64) GitHub repository ruleset rule main

Times in UTC · dashboard · how the merge queue works

@mergify
mergify Bot merged commit c114c06 into tinkerbell:main Oct 27, 2026
22 checks passed
@mergify mergify Bot removed the queued label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal Mergify to merge the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants