Repository navigation
agent_loop: pre-existing loop behaviours flagged during the #318 refactor review #322
Description
During review of #318, a refactor that changed no behaviour, Tiny Sweeper flagged the behaviours below. Each one already existed before the refactor, so they were left out of that PR. Each needs a decision and possibly a fix:
tool_searchbridge: it checks only the registry, so it does not suppress a duplicatetool_searchname.- Graceful mixed turn: it ignores
ContinueLoopfrom a control point, and it resets no recovery counters beforecontinue_from_queue_at_finishcan start another turn. - Dropped-tool-call nudge: it does not check the model-call budget before scheduling the nudge.
- Length stops: unterminated text-dialect blocks are dropped under a length stop, with no recovery attempt.
- Mixed structured-and-tools turns: they skip output validation.
- Promoted tools: their schemas are never prepared (
prepare) the way direct tool schemas are.
Context: tinyagents harness uplift (pi/OpenClaw comparison).
Activity
tinysweeper commentedon Oct 7, 2026
Pre-existing agent_loop behaviours (tool_search bridge, mixed turn handling, dropped-tool-call nudge, length stops, mixed turns, promoted tool schemas) flagged during #318 review; each needs a decision and possibly a fix.
Labelled
priority: p3.M3gA-Mind commentedon Nov 11, 2026
Triage (team#45), against main b6ed460: (c) is fixed by #339 (the nudge checks the model-call budget, response_recovery.rs:241/:551), and (d) is fixed by #532 when
text_dialect_calls_recoverableis set (:282, :474-485).Still present: (a) the bridge de-duplication (tool_surface.rs:271-285); (b) Graceful mixed turns drop
ContinueLoop(mixed_turn.rs:143-149; the helper is nowsettle_natural_finish); (e) mixed turns skip output validation.For (f): provider schema projection is applied (tools.rs:431-439), but the per-step PreparedToolSet transform isn't. Which did you mean?
Suggest splitting (a), (b), (e) and (f) into their own issues.
Keep a toolset's tool_search from being advertised twice
Honour a jump back to the model on a Graceful mixed turn
Validate a mixed turn's structured answer like a final answer
Test that a promoted tool's schema gets the provider preparation
M3gA-Mind commentedon Nov 11, 2026
Done. Items (c) and (d) were already fixed on main (#339, #532). The rest landed in four merged PRs:
tool_searchis no longer advertised next to the intrinsic bridge.