fix: Windows dev script quoting and empty-email validation message - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes found while capturing design screenshots on Windows:
pnpm run devfailed on Windows — the single quotes in--filter '@tinyrack/tinyauth-*'are not stripped by cmd.exe, so pnpm received a literally-quoted pattern and reported "No projects matched the filters". Switched to escaped double quotes, which work on all platforms.validation.email.required, added to en/ko/ja locales) and only then validate the format.Verification
pnpm --filter "@tinyrack/tinyauth-*" lsmatches all workspace packages under cmd.exenot-an-emailstill shows "Invalid email format"pnpm buildpasses (includes frontend tsc typecheck)biome checkclean on changed files