Skip to content

Analyzing and fixing resource leaks in ntoskrnl #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Analyzing and fixing resource leaks in ntoskrnl #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ntoskrnl/config/cmapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ CmpIsHiveAlreadyLoaded(IN HANDLE KeyHandle,
if (!NT_SUCCESS(Status)) return Loaded;

/* Don't touch deleted KCBs */
if (KeyBody->KeyControlBlock->Delete) return Loaded;
if (KeyBody->KeyControlBlock->Delete)
{
ObDereferenceObject(KeyBody);
return Loaded;
}

Hive = CONTAINING_RECORD(KeyBody->KeyControlBlock->KeyHive, CMHIVE, Hive);

Expand Down
2 changes: 0 additions & 2 deletions ntoskrnl/io/iomgr/bootlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,6 @@ IopCreateLogFile(VOID)

DPRINT("IopSaveBootLogToFile() called\n");

ExAcquireResourceExclusiveLite(&IopBootLogResource, TRUE);

RtlInitUnicodeString(&FileName,
L"\\SystemRoot\\rosboot.log");
InitializeObjectAttributes(&ObjectAttributes,
Expand Down
6 changes: 5 additions & 1 deletion ntoskrnl/io/iomgr/iofunc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,7 +1852,11 @@ NtLockFile(IN HANDLE FileHandle,
PreviousMode,
(PVOID *)&Event,
NULL);
if (Status != STATUS_SUCCESS) return Status;
if (Status != STATUS_SUCCESS)
{
ObDereferenceObject(FileObject);
return Status;
}
KeClearEvent(Event);
}

Expand Down
3 changes: 1 addition & 2 deletions ntoskrnl/io/pnpmgr/pnpmgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,7 @@ IopGetBusTypeGuidIndex(LPGUID BusTypeGuid)

if (!NewList)
{
/* Fail */
ExFreePool(PnpBusTypeGuidList);
/* Fail without destroying existing list data */
goto Quickie;
}

Expand Down
1 change: 1 addition & 0 deletions ntoskrnl/po/power.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ PopSetSystemPowerState(SYSTEM_POWER_STATE PowerState, POWER_ACTION PowerAction)
if (Fdo == DeviceObject)
{
DPRINT("An FDO was not attached\n");
ObDereferenceObject(Fdo);
return STATUS_UNSUCCESSFUL;
}
}
Expand Down
1 change: 1 addition & 0 deletions ntoskrnl/ps/psmgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ PsLocateSystemDll(VOID)
&HardErrorParameters,
OptionOk,
&HardErrorResponse);
ZwClose(FileHandle);
return Status;
}

Expand Down