Repository navigation
Docs: Slovak translation (/sk/) and versioned docs with a 5.x archive - #157
Merged
Merged
Conversation
Coverage Report for CI Build 39981778822Coverage remained the same at 98.78%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
tomaj
force-pushed
the
docs/slovak-versioned
branch
from
October 23, 2026 15:14
fe71d99 to
dd37258
Compare
…hive Every page has a Slovak counterpart under docs/sk/ with a language menu, hreflang links and Slovak structured data; English stays the default. The version menu links the latest docs at the root and the 5.x archive, which is the 5.0.0 README with its known mistakes listed. check-locales.py fails the docs check when a page exists in one language. Closes #76
tomaj
force-pushed
the
docs/slovak-versioned
branch
from
October 23, 2026 15:50
dd37258 to
a548947
Compare
9 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76
Summary
/sk/(39 pages: guide, all six drivers including FileSystem and Kafka, examples, frameworks, API, FAQ, changelog, contributing, authors, versioning, 5.x archive). VitePresslocales: English stays the default at the root (en-US), Slovak isskat/sk/, same paths (/guide/retry↔/sk/guide/retry). The top bar has a language menu, like bank-mails-parser.docs/.vitepress/theme/i18n.ts.hreflangen/sk/x-default links,og:localeplus the alternate,<html lang="sk">, and Slovak FAQPage/HowTo JSON-LD (## Časté otázky,## N. …steps with matching anchors).6.x (latest),5.x,Versioning) shows the version from the path. Older majors live in/<major>.x/and/sk/<major>.x/.guide/versioning.mdexplains how to archive 6.x when 7.x comes.docs/scripts/check-locales.py, whichnpm run docs:linksruns, fails when a page exists in only one language.master(after Add FileSystemDriver: a queue in a local directory #154 FileSystem and Add KafkaDriver for Apache Kafka through ext-rdkafka #155 Kafka). Slovak FileSystem + Kafka driver pages added; SK nav/sidebar updated; EN+SK copy brought in line with six built-in drivers.Review log (preview verify + full EN/SK audit, 2026-10-23)
Rebuilt VitePress from head
a548947; served locally; refreshed screenshots under/workspace/previews/157-verify-*.png.Previews look correct: language menu (Slovenčina/English), version menu EN
6.x (latest)/5.x/ Versioning and SK6.x (aktuálna)/5.x/ Verzie, EN+SK homes (six drivers in hero), filesystem SK, kafka SK, comparison SK (six-column table + driver cards), sidebar lists all six drivers, 5.x archive EN+SK (SK chrome + EN README body as designed). No broken UI.Audit (both locales): check-locales 39/39;
docs:linksgreen (~379); FAQ ### counts match on every page pair (SK section titleČasté otázky); heading counts match; all eight driver routes EN+SK present; hreflang en/sk/x-default + og:locale correct on sampled pages including FS/Kafka/5.x; i18nen/skkey sets equal. No content fixes required this round; commit unchanged.Review log (thorough re-review round, 2026-10-23)
Multi-angle pass on head after prior merge-ready prep. Already on current
master(no rebase needed).OK (clean):
npm run docs:linksgreen (diagrams, snippets, locales, SVG, edit/blob/tree links, linkinator 379 links)navEn/navSk,/5.x/+/sk/5.x/sidebars); i18n.ts key parity 47/47hreflangen/sk/x-default,og:locale+ alternate,<html lang>, FAQPage JSON-LD on FAQ pages; no<<<snippet leak in JSON-LDlang="en"); frameworks keep intentional four-driver factory setFixed this round:
examples/index.mdwas missing the "Are the examples tested?" FAQ and the CI sentence before the FAQ section — restored for EN/SK FAQ parity (6/6).docs/contributing.md+docs/sk/contributing.mdstill said three brokers / "all four variables" after Kafka landed; aligned with rootCONTRIBUTING.md/composer test:integration(HERMES_TEST_KAFKA, five variables). Punctuation fix in rootCONTRIBUTING.md.Second pass after fixes: FAQ/heading counts match; docs:links still green. Single commit amended (
a548947), Tomas Majer.Review log (merge-ready pass on current master)
docs/slovak-versionedontoorigin/master(8f4a5c5, post-Add FileSystemDriver: a queue in a local directory #154/Add KafkaDriver for Apache Kafka through ext-rdkafka #155). Conflicts infaq.md/overview.mdresolved keeping master FileSystem + Kafka content.docs/sk/guide/drivers/filesystem.mdanddocs/sk/guide/drivers/kafka.md.sidebarSkindocs/site-nav.ts) with FileSystem and Kafka entries.guide/drivers/overview.mddelayed/ack FAQsguide/delayed.mdFAQ + where-stored + descriptionexamples/priority.mdguide/deployment.mdFileSystem rename noteCHANGELOG.md[Unreleased]Fixed bullet for six-driver docs consistency.npm run docs:links(local): green — check-locales ok 39 pages, linkinator clean.<tomasmajer@gmail.com>. Force-pushed with--force-with-lease.Decisions to review
/5.x/,/sk/5.x/).lang="en", with a Slovak notice.newmissing on the shutdown classes,RedisShutdowngiven a Predis client, retry being instant on RabbitMQ/SQS, and RedisSetDriver never delivers delayed and retried messages (SPOP on a sorted set) #95.http://links, which now point to their current https addresses so the link check passes.alttexts are translated.examples/, so both languages show the same files.noindexon the archive. It is the only 5.x documentation, and/sk/5.x/uses hreflang to point at/5.x/.Verification
npm run docs:links: all green, including diagrams:check, check-snippets, check-locales (39 pages in both languages), build, check-svg, edit/blob/tree links and linkinator over the whole site at/hermes/.ok 39 pages in English and Slovak.a548947after force-push: all required checks green (Docs links and SVG with check-locales 39, PHP 8.4/8.5/prefer-lowest, Infection, Rector, PHPStan, CodeQL, Examples including filesystem + kafka). One Example csv-import fail was a RabbitMQ containereacceson.erlang.cookie(infra flake, unrelated to docs); re-ran failed Examples jobs → pass.Previews
Captured under
/workspace/previews/(open locally; not hosted externally):157-home-en-six-drivers.png— EN home, six drivers157-home-sk-six-drivers.png— SK home, six drivers157-drivers-comparison-sk.png— SK drivers comparison with FileSystem + Kafka157-filesystem-sk.png— SK FileSystem driver page157-kafka-sk.png— SK Kafka driver page157-nav-sk-lang-version.png— SK chrome with language + version controls76-language-switcher.png,76-version-switcher.png,76-version-switcher-sk.png,76-sk-home.png,76-sk-page.png,76-5x-archive.png,76-5x-archive-sk.pngMerge notes
masterwith FileSystem + Kafka. No remaining conflict with Add FileSystemDriver: a queue in a local directory #154/Add KafkaDriver for Apache Kafka through ext-rdkafka #155.