Skip to content

Pin @excalidraw/utils to 0.1.5 so the docs diagram check builds again - #178

Merged
tomaj merged 1 commit into
masterfrom
fix/excalidraw-utils-pin
Oct 26, 2026
Merged

tomaj merged 1 commit into
masterfrom
fix/excalidraw-utils-pin

Conversation

@tomaj

@tomaj tomaj commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

@excalidraw/utils 0.1.7, merged with the Dependabot docs group bump (#172), no longer exports exportToSvg, which docs/scripts/diagrams-browser.js imports. The Docs links and SVG job of Deploy Documentation failed on master a705a86 (No matching export ... for import "exportToSvg"). The site itself still deployed.

This pins @excalidraw/utils back to 0.1.5 (exact, as before) and adds a Dependabot ignore for >0.1.5 with a comment, so the group bump does not bring it back until the script is ported to the new API. puppeteer-core 25.15.0 from the same bump stays.

It also fixes the examples FAQ (EN and SK): it named only filesystem among the recipes CI runs, but the Examples workflow also runs emit-after-commit (no services) and kafka.

No library code or CHANGELOG changes (CHANGELOG date stays 2026-10-19). Infection: no PHP lines changed.

Review log

Full 6.0 review of master a705a86 plus this branch.

  • Round 1:
    • Upgrade simulation: a 5.x app (RetryTrait handler, own canRetry()/maxRetry() handler that returns false, Dispatcher::emit(), Emitter subclass) run on 5.0.0 and on this branch. Retries are identical (52 and 3 handle calls). 6.0 raises exactly 3 E_USER_DEPRECATED + 3 warnings (one per handler class, one per Dispatcher for emit()), with the texts in UPGRADE-6.0 and logging.md. The Emitter subclass fails with "cannot extend final class", as documented. The migrated app (RetryableHandlerInterface, BufferedEmitter with $pdo->inTransaction(...)) has 0 deprecations, canRetry() === false skips the retry, and the buffer keeps the priority.
    • Examples vs docs: every <<< @/../examples/... include exists, and EN and SK use the same includes.
    • Docs vs code: every Tomaj\Hermes\… symbol in PHP blocks (docs, README, UPGRADE) exists. API reference signatures and defaults match src/ for every class, interface and driver, in EN and SK. Logging tables match the log strings in src/.
    • README: PHP blocks lint, retry and BufferedEmitter sections match the code.
    • Finding (low): examples FAQ listed only filesystem. Fixed.
  • Round 2: EN/SK parity by inline-code tokens and link counts per page (only translated placeholders differ). BufferedEmitter docs re-checked against the code (re-entrant flush(), partial failure, discard(): int, Countable). Every examples/ folder is in examples/README.md and in CI. No findings.
  • Round 3: re-ran the parity and include checks, docs build and composer phpunit on the amended commit. No findings.

Verification

  • npm ci && npm run docs:build in docs/
  • npm run diagrams:check: 60 diagrams are up to date
  • npm audit: 0 vulnerabilities
  • composer phpunit: 397 tests, 30 skipped (services)
  • 5.0.0 → 6.0 upgrade simulation as in the review log
  • CI on this PR (all jobs incl. Docs links and SVG, PHP 8.6)

@tomaj tomaj added this to the 6.0.0 milestone Oct 25, 2026
@tomaj tomaj self-assigned this Oct 25, 2026
@coveralls

coveralls commented Oct 25, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40220552507

Coverage remained the same at 99.288%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 702
Covered Lines: 697
Line Coverage: 99.29%
Coverage Strength: 23.33 hits per line

💛 - Coveralls

0.1.7 (from the Dependabot docs group bump) no longer exports exportToSvg,
which scripts/diagrams-browser.js imports, so the Docs links and SVG job
failed on master. Pin the working version and tell Dependabot to skip newer
releases until the script is ported.

The examples FAQ now lists every recipe the Examples workflow runs without
services or with Kafka: filesystem, emit-after-commit and kafka.
@tomaj
tomaj force-pushed the fix/excalidraw-utils-pin branch from 9a586ea to 3cd4984 Compare October 25, 2026 18:17
@tomaj
tomaj merged commit 1c396df into master Oct 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants