Repository navigation
Pin @excalidraw/utils to 0.1.5 so the docs diagram check builds again - #178
Merged
Merged
Conversation
Coverage Report for CI Build 40220552507Coverage remained the same at 99.288%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
0.1.7 (from the Dependabot docs group bump) no longer exports exportToSvg, which scripts/diagrams-browser.js imports, so the Docs links and SVG job failed on master. Pin the working version and tell Dependabot to skip newer releases until the script is ported. The examples FAQ now lists every recipe the Examples workflow runs without services or with Kafka: filesystem, emit-after-commit and kafka.
tomaj
force-pushed
the
fix/excalidraw-utils-pin
branch
from
October 25, 2026 18:17
9a586ea to
3cd4984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@excalidraw/utils0.1.7, merged with the Dependabot docs group bump (#172), no longer exportsexportToSvg, whichdocs/scripts/diagrams-browser.jsimports. The Docs links and SVG job of Deploy Documentation failed on mastera705a86(No matching export ... for import "exportToSvg"). The site itself still deployed.This pins
@excalidraw/utilsback to0.1.5(exact, as before) and adds a Dependabotignorefor>0.1.5with a comment, so the group bump does not bring it back until the script is ported to the new API.puppeteer-core25.15.0 from the same bump stays.It also fixes the examples FAQ (EN and SK): it named only
filesystemamong the recipes CI runs, but theExamplesworkflow also runsemit-after-commit(no services) andkafka.No library code or CHANGELOG changes (CHANGELOG date stays
2026-10-19). Infection: no PHP lines changed.Review log
Full 6.0 review of master
a705a86plus this branch.RetryTraithandler, owncanRetry()/maxRetry()handler that returnsfalse,Dispatcher::emit(),Emittersubclass) run on 5.0.0 and on this branch. Retries are identical (52 and 3 handle calls). 6.0 raises exactly 3E_USER_DEPRECATED+ 3warnings (one per handler class, one perDispatcherforemit()), with the texts in UPGRADE-6.0 andlogging.md. TheEmittersubclass fails with "cannot extend final class", as documented. The migrated app (RetryableHandlerInterface,BufferedEmitterwith$pdo->inTransaction(...)) has 0 deprecations,canRetry() === falseskips the retry, and the buffer keeps the priority.<<< @/../examples/...include exists, and EN and SK use the same includes.Tomaj\Hermes\…symbol in PHP blocks (docs, README, UPGRADE) exists. API reference signatures and defaults matchsrc/for every class, interface and driver, in EN and SK. Logging tables match the log strings insrc/.BufferedEmittersections match the code.filesystem. Fixed.BufferedEmitterdocs re-checked against the code (re-entrantflush(), partial failure,discard(): int,Countable). Everyexamples/folder is inexamples/README.mdand in CI. No findings.composer phpuniton the amended commit. No findings.Verification
npm ci && npm run docs:buildindocs/npm run diagrams:check: 60 diagrams are up to datenpm audit: 0 vulnerabilitiescomposer phpunit: 397 tests, 30 skipped (services)