Switch Heroku deployment to Ruby buildpack and isolate Docker for distribution#544
Merged
Conversation
a6591c9 to
2f73112
Compare
2f73112 to
abbfa47
Compare
abbfa47 to
7eb2f8d
Compare
7eb2f8d to
fa7f2a3
Compare
fa7f2a3 to
a271688
Compare
a271688 to
35f7422
Compare
35f7422 to
0866dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Initially, this PR attempted to migrate the Heroku deployment to a Docker-based pipeline (container stack via heroku.yml). However, the ENTRYPOINT ["bundle"] in our Dockerfile—which is highly optimized for DockerHub distribution—conflicted with Heroku's internal container runtime wrapper (/bin/sh -c), causing startup crashes.
Solution
To keep the Dockerfile clean and pristine for future DockerHub/GHCR distribution without dirtying it with Heroku-specific workarounds, we changed our strategy to fall back to Heroku's standard Ruby Buildpack (heroku-26).
Changes
Testing