Skip to content

chore(eslint): use 'defineConfig' and update 'eslint', '@eslint/js' to v9.39.3#297

Merged
kimyouknow merged 3 commits intotoss:mainfrom
sukvvon:chore/add-eslint-define-config
Mar 6, 2026
Merged

chore(eslint): use 'defineConfig' and update 'eslint', '@eslint/js' to v9.39.3#297
kimyouknow merged 3 commits intotoss:mainfrom
sukvvon:chore/add-eslint-define-config

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Oct 21, 2025

Overview

  • Use defineConfig from eslint/config for better type safety (replaces JSDoc type annotation)
  • Update eslint and @eslint/js from ^9.16.0 to ^9.39.3

Checklist

  • Did you write the test code?
  • Have you run yarn run fix to format and lint the code and docs?
  • Have you run yarn run test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

@sukvvon sukvvon requested a review from kimyouknow as a code owner October 21, 2025 15:34
@sukvvon sukvvon force-pushed the chore/add-eslint-define-config branch from 3b6da10 to 0da34b0 Compare October 22, 2025 01:12
kimyouknow
kimyouknow previously approved these changes Oct 22, 2025
Copy link
Collaborator

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sukvvon sukvvon force-pushed the chore/add-eslint-define-config branch from 2115551 to 4f2b5b2 Compare March 5, 2026 06:44
@sukvvon sukvvon changed the title chore(eslint): add 'defineConfig' for better type safety chore(eslint): use 'defineConfig' and update 'eslint', '@eslint/js' to v9.39.3 Mar 5, 2026
@sukvvon sukvvon requested a review from kimyouknow March 5, 2026 07:06
Copy link
Collaborator

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kimyouknow kimyouknow merged commit c4e0195 into toss:main Mar 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants