Skip to content

fix(ci): exclude integration tests from test-core target#102

Merged
iap merged 1 commit into
devfrom
feature/fix-makefile-test-core
May 15, 2026
Merged

fix(ci): exclude integration tests from test-core target#102
iap merged 1 commit into
devfrom
feature/fix-makefile-test-core

Conversation

@iap
Copy link
Copy Markdown
Contributor

@iap iap commented May 15, 2026

The --no-match-path CLI flag overrides foundry.toml's no_match_path setting instead of adding to it. Integration tests (which require supersim on port 9545) were being included in test-core, causing failures when supersim is not running.

Fix: use brace glob test/{invariant,integration}/** to exclude both.

make ci-fast  # exit 0

Summary by CodeRabbit

  • Chores
    • Updated test execution configuration to exclude integration tests from core test runs, refining the test suite execution workflow.

Review Change Stack

test-core was running integration tests (which require supersim on port 9545)
because --no-match-path on the command line overrides foundry.toml's
no_match_path setting rather than adding to it.

Use brace glob to exclude both invariant and integration tests.
@iap iap requested a review from a team as a code owner May 15, 2026 02:05
@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a81bb42e-806e-4c31-ac0f-c8603503d9b9

📥 Commits

Reviewing files that changed from the base of the PR and between 77d6814 and 726b155.

📒 Files selected for processing (1)
  • contracts/Makefile

Walkthrough

The test-core make target in contracts/Makefile is updated to exclude integration tests alongside invariant tests when running forge test via the --no-match-path filter.

Changes

Test Target Configuration

Layer / File(s) Summary
Update test-core to exclude integration tests
contracts/Makefile
The test-core target's forge test filter is broadened from excluding test/invariant/** to excluding both test/invariant/** and test/integration/**.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little hop, a filter grows,
Integration tests now out it goes,
Invariant friends still left behind,
Faster runs for testing's mind!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the problem and fix well, but is missing several required template sections including Scope, Verification, Risk Review, and Governance sections. Complete the description template by adding Scope, Verification, Risk Review, and Governance sections with appropriate checkboxes checked.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: excluding integration tests from the test-core target in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fix-makefile-test-core

Comment @coderabbitai help to get the list of available commands and usage tips.

@iap iap merged commit 218d460 into dev May 15, 2026
20 checks passed
@iap iap deleted the feature/fix-makefile-test-core branch May 15, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant