You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Properly handles success false/ 400 server error upon successful creation of categories (This occurs when created item already exist) by logging the error message in the form and thus not resubmitting. Function extended to Properties,Categories etc to avoid similar issues. issue: feat: Add categories sometimes return 400 after successful addition but failed fetch #56
This PR resolves dark mode styling issues in the onboarding flow and enhances the sidebar with descriptive subtext. It also standardizes form submission states and error handling.
🚀 Key Improvements
Dark mode support for onboarding via CSS variables.
Informative subtext added to sidebar navigation links.
Consistent loading and error states across all CRUD forms.
Better API result extraction logic.
💡 Minor Suggestions
Extract duplicated API helper functions into a shared utility file.
The use of min-height on sidebar items is a good defensive CSS practice.
The reason will be displayed to describe this comment to others. Learn more.
The logic for createApiBusinessError and extractCategoryMutationResult is duplicated across almost all API service files (categories, parties, reminders, wallets). This should be moved to a shared utility like apiHelpers.ts to reduce technical debt and maintenance overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.