Skip to content

Resolve Darkmode issue in onboarding && Add tooltip for hover on lsidebar links#62

Merged
nfebe merged 3 commits intodevfrom
bugs
Feb 23, 2026
Merged

Resolve Darkmode issue in onboarding && Add tooltip for hover on lsidebar links#62
nfebe merged 3 commits intodevfrom
bugs

Conversation

@Lantum-Brendan
Copy link
Collaborator

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2026

Deploying trakli-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93d943f
Status: ✅  Deploy successful!
Preview URL: https://9f1800c1.trakli-dev.pages.dev
Branch Preview URL: https://bugs.trakli-dev.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2026

Deploying webui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93d943f
Status: ✅  Deploy successful!
Preview URL: https://f465ad55.webui-9fh.pages.dev
Branch Preview URL: https://bugs.webui-9fh.pages.dev

View logs

@Lantum-Brendan
Copy link
Collaborator Author

Summary:
Commit no!: Resolves inconsistent application of darkmode on home page.
Commit no2: Adds sub text on the sidebar links addressing issue: #58

commit no3:

@Lantum-Brendan Lantum-Brendan marked this pull request as ready for review February 14, 2026 02:08
@Lantum-Brendan Lantum-Brendan requested a review from nfebe February 14, 2026 02:08
@sourceant
Copy link

sourceant bot commented Feb 14, 2026

Code Review Summary

This PR resolves dark mode styling issues in the onboarding flow and enhances the sidebar with descriptive subtext. It also standardizes form submission states and error handling.

🚀 Key Improvements

  • Dark mode support for onboarding via CSS variables.
  • Informative subtext added to sidebar navigation links.
  • Consistent loading and error states across all CRUD forms.
  • Better API result extraction logic.

💡 Minor Suggestions

  • Extract duplicated API helper functions into a shared utility file.
  • The use of min-height on sidebar items is a good defensive CSS practice.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

} from '~/types/category';
import { buildIconPayload, extractResponseData } from './apiHelpers';

function createApiBusinessError(message: string, errors: string[] = []): Error {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for createApiBusinessError and extractCategoryMutationResult is duplicated across almost all API service files (categories, parties, reminders, wallets). This should be moved to a shared utility like apiHelpers.ts to reduce technical debt and maintenance overhead.

Suggested change
function createApiBusinessError(message: string, errors: string[] = []): Error {
// Move these functions to @/services/api/apiHelpers.ts and import them instead.

@Lantum-Brendan
Copy link
Collaborator Author

Attached images : 1 darkmode in onboarding applied, sub-titles on sidebar links added.

image

buttons disabled upon submit on all pages
image

@nfebe nfebe merged commit 66e1ac8 into dev Feb 23, 2026
5 checks passed
@nfebe nfebe deleted the bugs branch February 23, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants