fix(acurator): add more check for AssetIssueActuator #6525
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
changed the title
warku123
approved these changes
Jan 26, 2026
| // make sure FrozenSupply.expireTime not overflow | ||
| if (chainBaseManager.getForkController().pass(ForkBlockVersionEnum.VERSION_4_8_1) | ||
| && assetIssueContract.getStartTime() | ||
| >= Long.MAX_VALUE - next.getFrozenDays() * FROZEN_PERIOD) { |
Contributor
There was a problem hiding this comment.
what about using > instead of '>=' and making the codes more readable, such as:
if (chainBaseManager.getForkController().pass(ForkBlockVersionEnum.VERSION_4_8_1)) {
long frozenPeriod = next.getFrozenDays() * FROZEN_PERIOD;
if (assetIssueContract.getStartTime() > Long.MAX_VALUE - frozenPeriod) {
throw new ContractValidateException(
"Start time and frozen days would cause expire time overflow");
}
}
|
|
||
| message FrozenSupply { | ||
| int64 frozen_amount = 1; | ||
| int64 frozen_amount = 1; //asset amount |
Contributor
There was a problem hiding this comment.
add blank after '//', --> // asset amount
| int64 total_supply = 4; | ||
| repeated FrozenSupply frozen_supply = 5; | ||
| int32 trx_num = 6; | ||
| int32 trx_num = 6; // The fields trx_num and num are only used to calculate price and avoid usage of decimal, asset price = trx_num / num |
Contributor
There was a problem hiding this comment.
Using // The fields trx_num and num define the exchange rate: num tokens can be purchased with trx_num TRX. This avoids using decimals. Example: trx_num=1, num=100 means 1 TRX buys 100 tokens. ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details