maintenance: allow multiple client ca files#35
Merged
Conversation
tschaefer
force-pushed
the
tschaefer/feature/client-management
branch
from
a0b5848 to
2ad7964
Compare
There was a problem hiding this comment.
Pull request overview
Updates the gRPC mTLS authentication flow to support validating a client certificate against multiple CA certificates stored as separate PEM files, rather than a single CA PEM file.
Changes:
- Change CA location from a single file path to a CA directory (
certs.d) containing multiple*.pemfiles. - Update authentication to glob CA PEM files and accept the client cert if any CA validates it.
- Adjust tests to create a CA directory and write a CA PEM file into it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
internal/grpc/auth.go |
Switches CA lookup to a directory + *.pem glob; validates client cert against each CA file. |
internal/grpc/auth_test.go |
Updates test fixture setup to create CA directory and write CA PEM file into it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tschaefer
force-pushed
the
tschaefer/feature/client-management
branch
from
2ad7964 to
1c39745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.