Skip to content

maintenance: add healthz service#37

Merged
tschaefer merged 1 commit intomainfrom
tschaefer/maintenance/healthz-endpoint
Feb 25, 2026
Merged

maintenance: add healthz service#37
tschaefer merged 1 commit intomainfrom
tschaefer/maintenance/healthz-endpoint

Conversation

@tschaefer
Copy link
Owner

No description provided.

@gitguardian
Copy link

gitguardian bot commented Feb 25, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
23265588 Triggered Generic High Entropy Secret 43ba2d5 internal/healthz/server_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated health check HTTP service (“healthz”) to the Finch manager process, wiring it through the manager runtime, CLI flags, and container startup so operators can probe basic service/DB readiness independently of the main HTTP/Auth ports.

Changes:

  • Introduces a new internal/healthz HTTP server with /healthz handler backed by a DB ping/readiness check.
  • Refactors Manager.Run to accept an Addresses struct and starts/stops the new healthz server alongside existing servers.
  • Adds a new CLI flag and Docker runtime arg for configuring the healthz listen address, plus updates tests accordingly.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/manager/manager_test.go Updates manager run test to supply a healthz listen address.
internal/manager/manager.go Refactors Run to take an address bundle and adds healthz server lifecycle management.
internal/healthz/server.go Implements the new healthz HTTP server and /healthz handler.
internal/healthz/server_test.go Adds unit tests for healthy/unhealthy/method handling of the healthz handler.
internal/database/database.go Adds Database.Ping(ctx) used by healthz to validate DB readiness.
cmd/run/run.go Adds --server.healthz-address flag and passes it into manager startup.
Dockerfile Supplies the new healthz address flag in the container CMD.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tschaefer tschaefer force-pushed the tschaefer/maintenance/healthz-endpoint branch from ae0b46a to 43ba2d5 Compare February 25, 2026 18:47
@tschaefer tschaefer marked this pull request as ready for review February 25, 2026 18:49
@tschaefer tschaefer merged commit 35544df into main Feb 25, 2026
2 checks passed
@tschaefer tschaefer deleted the tschaefer/maintenance/healthz-endpoint branch February 25, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants