fix: RectDiffExpansion Solver did not expand always #56
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0hmX
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
From one of your snapshots, isnt this going through the board outline?
|
@seveibar added a utility to draw the board outline. |
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
RectDiffExpansion failed to expand because the obstacle and capacity mesh node given were sometimes outdated. We fix this by moving the logic of finding the collision box inside the
expandRectFromSeed. We pass both the index inside and do the search inside.