-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Add customization for local packages structure #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds the possibility to change standard packages structure in generated project
|
👋 Hi @pepicrft @fortmarek, When you have a moment, could you please take a look at this PR? I'm adding support for structured folders in local packages, based on this discussion. I'd really appreciate your feedback or a merge if everything looks good 🙏 P.S. There’s a related PR #232, but the original author is no longer active and unable to continue. This new PR includes all the necessary additions and refinements to move the feature forward. |
# Conflicts: # Package.resolved
|
Let's wait for @fortmarek's review. |
|
@pepicrft @fortmarek Hi! Just a gentle ping to review this request |
| public let path: AbsolutePath | ||
| public let groupPath: String? | ||
| public let excludingPath: String? | ||
| public let keepStructure: Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the naming here confusing. What's being excluded? What structure is kept? How do they relate to group path? Or to the default group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could suggest something like this instead
public let customGroupPath: String? = "CustomGroup" // Path/To/My/Lib -> Packages/CustomGroup/Lib
public let excludingPathPrefix: String? = "Path/To" // Path/To/My/Lib -> Packages/My/Lib
public let keepOriginalStructure: Bool = true // Path/To/My/Lib -> Project/Path/To/My/Lib
pepicrft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @fortmarek
This commit adds the possibility to change standard packages structure in generated project