[feat] Supersede Project.external with Project.type
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pepicrft
changed the title
Project.typeProject.external with Project.type
fortmarek
approved these changes
Nov 14, 2024
| ) | ||
| } | ||
|
|
||
| public static func empty( |
Member
There was a problem hiding this comment.
Should we a) deprecate it as well b) don't consider test helpers as part of the public interface?
I'd probably deprecate, so we don't cause a breaking change for tuist/tuist
pepicrft
changed the title
Project.external with Project.type Project.external with Project.type
pepicrft
force-pushed
the
project-type
branch
from
ca7adb2 to
6f2b6b9
Compare
Which allows passing a hash for external projects to speed up the hashing of the graph.
pepicrft
force-pushed
the
project-type
branch
from
6f2b6b9 to
3eb2289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of debugging this issue, which we couldn't reproduce consistently (e.g., its behavior changes throughout terminal types), @fortmarek and I had the idea of skipping the hashing of external dependencies, since their hash can be obtained from the lock file.
To achieve this, I'm introducing a new attribute,
Project.type, which supersedesProject.external. This attribute can then include a hash when declaring a projects external. The hashing logic can then consider this to skip the hashing altogether. Thanks to this, we'll improve our performance.Note
This doesn't mitigate the issue, but since it always happens with the same external dependency, we won't run into it.