Skip to content

Drop deprecated .alert-dismissible remaining usage#42520

Merged
mdo merged 1 commit into
v6-devfrom
v6-dev-jd-drop-deprecated-alert-dismissible
Jun 18, 2026
Merged

Drop deprecated .alert-dismissible remaining usage#42520
mdo merged 1 commit into
v6-devfrom
v6-dev-jd-drop-deprecated-alert-dismissible

Conversation

@julien-deramond

@julien-deramond julien-deramond commented Jun 16, 2026

Copy link
Copy Markdown
Member

Description

Spotted by #42487.

The .alert-dismissible class is not needed anymore for the Alert component, as the close button (or any other things) can be used associated to the use of the .ms-auto class:

  • Alert docs is updated to reflect the right DOM in the "Dismiss" section, but also to not mention anymore .alert-dismissible
  • The migration guide is improved to reference that
  • The Cheatsheet example is fixed
  • The visual tests are fixed too
Screenshot 2026-06-16 at 22 04 53

Live previews

Comment thread js/tests/visual/alert.html
@julien-deramond julien-deramond requested a review from mdo June 16, 2026 20:07
@julien-deramond julien-deramond marked this pull request as ready for review June 16, 2026 20:07
@julien-deramond julien-deramond requested a review from a team as a code owner June 16, 2026 20:07

@mdo mdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo merged commit 54e0af0 into v6-dev Jun 18, 2026
12 checks passed
@mdo mdo deleted the v6-dev-jd-drop-deprecated-alert-dismissible branch June 18, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants