fix: don't load CI-only .github/scripts at runtime (fixes #306) - #307
Open
alikhizarsohal wants to merge 1 commit into
Open
fix: don't load CI-only .github/scripts at runtime (fixes #306)#307alikhizarsohal wants to merge 1 commit into
alikhizarsohal wants to merge 1 commit into
Conversation
src/index.js eagerly require()'d two CI-only scripts (update-release, trigger-workflow) and re-exported them as `releaseScripts`. update-release.js requires @octokit/core, which is ESM-only, so on Node 20+ (the only Node range CLI 6.x supports) every CLI invocation crashed with ERR_REQUIRE_ESM before any command ran. These scripts are release automation invoked directly by file path in .github/workflows/release.yml, never through the package export, and no source under src/ references releaseScripts. Removing them from the runtime entry point fixes the crash with no behavior change. Verified on Node 20.18.0: module loads cleanly, 192 tests pass, lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306
src/index.jseagerlyrequire()'d two CI-only scripts (update-release,trigger-workflow) and re-exported them asreleaseScripts.update-release.jsrequires@octokit/core, which is ESM-only, so on Node 20+ (the only Node range CLI 6.x supports) every CLI invocation crashed withERR_REQUIRE_ESMbefore any command ran.These scripts are release automation invoked directly by file path in
.github/workflows/release.yml, never through the package export, and no source undersrc/referencesreleaseScripts. Removing them from the runtime entry point fixes the crash with no behavior change.Verified on Node 20.18.0: module loads cleanly, 192 tests pass, lint clean.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.