Refactor namespace handling in Docker registry Helm chart - #158
Open
bwdmr wants to merge 1 commit into
Open
Conversation
- Create a reusable helper template "docker-registry.namespace" in _helpers.tpl
- Replace all instances of "{{ .Values.namespace | default .Release.Namespace }}"
with "{{ include "docker-registry.namespace" . }}" for consistency
- Apply this change across all resource templates (deployment, service,
configmap, secret, cronjob, pvc, etc.)
This refactoring improves maintainability and ensures consistent namespace
handling throughout the chart, particularly for multi-namespace deployments
in combined charts.
Signed-off-by: bwdmr <pbwo@protonmail.ch>
bwdmr
force-pushed
the
compatreleasenamespace
branch
from
March 15, 2025 09:01
cb49b7f to
8b705eb
Compare
joshsizer
self-requested a review
March 27, 2025 00:48
Collaborator
|
@bwdmr Please sign your commits! Otherwise I won't be able to merge this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring improves maintainability and ensures consistent namespace handling throughout the chart, particularly for multi-namespace deployments in combined charts.