Repository navigation
Conversation
|
I agree this is probably worth doing, but to be clear, I don't want these types under semver, as the shape of them is basically private, and ember-content-mapper is like... "intimately knowledgeable" of what glint is doing |
|
at a minimum, I'd want to make sure that we add nice comment blocks on each of the exported types |
39a3366 to
f26ad75
Compare
johanrd
changed the title
| // Private API for ember-content-mapper. Not covered by semver: these follow the | ||
| // transform's internals and can change in any release. | ||
|
|
||
| /** Loads the Glint environment that drives the transform for a project. */ |
There was a problem hiding this comment.
these are not specific enough -- and I would not expect the details of each of these to fit all one one line
There was a problem hiding this comment.
Fair. Since you maintain both, I may be creating more noise than help with this. Happy to close it. We can consider another round when 7.1 is stable, perhaps.
There was a problem hiding this comment.
Waiting a bit sounds grand
There was a problem hiding this comment.
@NullVoxPopuli talking of, vue has now settled on their content-mapper architecture:
Adds
@glint/ember-tsc/-private/content-mapper, next to-private/dsl. It is not covered by semver. It re-exports what ember-content-mapper imports through./*today:GlintEnvironmentfromconfig/index: open-project.js#L7 (runtime,GlintEnvironment.load) and projects.js#L2TransformErrorandTransformedModulefromtransform/template/transformed-module: transform.js#L3CorrelatedSpanandGlimmerASTMappingTree: mappings.js#L3-L5Each export has a doc comment, and the file header says it can change in any release.
🤖 Generated with Claude Code